Re: diff: ftpd(8): fix for sign-compare compiler warnings

2018-12-06 Thread Jan Klemkow
On Tue, Nov 27, 2018 at 09:03:15AM +0100, Theo Buehler wrote: > On Sun, Nov 25, 2018 at 12:32:23AM +0100, Jan Klemkow wrote: > > This diff fixes some -Wsign-compare compiler warnings in ftpd(8) by > > using the right types for 'i' and 'len'. One warning is left, but I > > don't see that it's fixab

Re: diff: ftpd(8): fix for sign-compare compiler warnings

2018-11-27 Thread Theo Buehler
On Sun, Nov 25, 2018 at 12:32:23AM +0100, Jan Klemkow wrote: > Hi, > > This diff fixes some -Wsign-compare compiler warnings in ftpd(8) by > using the right types for 'i' and 'len'. One warning is left, but I > don't see that it's fixable without suppressing the warning by a cast of > len to size

diff: ftpd(8): fix for sign-compare compiler warnings

2018-11-24 Thread Jan Klemkow
Hi, This diff fixes some -Wsign-compare compiler warnings in ftpd(8) by using the right types for 'i' and 'len'. One warning is left, but I don't see that it's fixable without suppressing the warning by a cast of len to size_t. And casting might be controversial in this case?! /usr/src/libexec/