Re: de-hole some structs on amd64

2018-05-31 Thread Amit Kulkarni
Hi, Is there any feedback on this? Thanks > > > I tested removing some slop (i.e. structure packing/de-holing) on amd64, > > > this went through a full kernel + userland build. > > > > > > > Parts of this are probably okay, but there's some stuff which needs better > > placement vs comments an

Re: de-hole some structs on amd64

2018-05-21 Thread Amit Kulkarni
> > I tested removing some slop (i.e. structure packing/de-holing) on amd64, > > this went through a full kernel + userland build. > > > > Parts of this are probably okay, but there's some stuff which needs better > placement vs comments and at least one move which needs a justification for > it b

Re: de-hole some structs on amd64

2018-05-20 Thread Philip Guenther
On Sat, May 19, 2018 at 4:30 PM, Amit Kulkarni wrote: > > I tested removing some slop (i.e. structure packing/de-holing) on amd64, > this went through a full kernel + userland build. > Parts of this are probably okay, but there's some stuff which needs better placement vs comments and at least on

de-hole some structs on amd64

2018-05-19 Thread Amit Kulkarni
Hi, I tested removing some slop (i.e. structure packing/de-holing) on amd64, this went through a full kernel + userland build. struct proc 20 bytes (6 places) --> 4 bytes (2 places) struct process 28 bytes (6 places) --> 4 bytes (1 place) struct vm_map 8 bytes (2 places) --> 0 bytes Thanks d