Re: cron: NULL pointer dereference in load_entry()

2011-05-10 Thread Kenneth R Westerback
On Tue, May 10, 2011 at 10:01:00PM -0400, Lawrence Teo wrote: > On Tue, May 10, 2011 at 08:46:04AM -0400, Kenneth R Westerback wrote: > > On Tue, May 10, 2011 at 06:57:29AM +0200, Otto Moerbeek wrote: > > > On Mon, May 09, 2011 at 08:51:01PM -0400, Lawrence Teo wrote: > > > > > > > In the load_ent

Re: cron: NULL pointer dereference in load_entry()

2011-05-10 Thread Lawrence Teo
On Tue, May 10, 2011 at 08:46:04AM -0400, Kenneth R Westerback wrote: > On Tue, May 10, 2011 at 06:57:29AM +0200, Otto Moerbeek wrote: > > On Mon, May 09, 2011 at 08:51:01PM -0400, Lawrence Teo wrote: > > > > > In the load_entry() function in cron's entry.c, calloc() is called > > > but its return

Re: cron: NULL pointer dereference in load_entry()

2011-05-10 Thread Kenneth R Westerback
On Tue, May 10, 2011 at 06:57:29AM +0200, Otto Moerbeek wrote: > On Mon, May 09, 2011 at 08:51:01PM -0400, Lawrence Teo wrote: > > > In the load_entry() function in cron's entry.c, calloc() is called > > but its return value is never checked to see if it is NULL, > > potentially causing a NULL poi

Re: cron: NULL pointer dereference in load_entry()

2011-05-09 Thread Otto Moerbeek
On Mon, May 09, 2011 at 08:51:01PM -0400, Lawrence Teo wrote: > In the load_entry() function in cron's entry.c, calloc() is called > but its return value is never checked to see if it is NULL, > potentially causing a NULL pointer dereference. Since crontab(1) > shares code with cron, it is affecte

cron: NULL pointer dereference in load_entry()

2011-05-09 Thread Lawrence Teo
In the load_entry() function in cron's entry.c, calloc() is called but its return value is never checked to see if it is NULL, potentially causing a NULL pointer dereference. Since crontab(1) shares code with cron, it is affected as well. The following diff adds the check for NULL, and also moves