Re: copy and paste error in rb tree code

2018-10-09 Thread Theo Buehler
On Tue, Oct 09, 2018 at 01:02:11PM +1000, David Gwynne wrote: > According to https://github.com/FRRouting/frr/pull/3106, Coverity thinks > I made a copy and paste error regarding one of the augment calls in > RBT_REMOVE. I'm inclined to agree. > > The augment code is only used by uvm_map.c, and it

Re: copy and paste error in rb tree code

2018-10-08 Thread Philip Guenther
On Mon, Oct 8, 2018 at 6:03 PM David Gwynne wrote: > According to https://github.com/FRRouting/frr/pull/3106, Coverity thinks > I made a copy and paste error regarding one of the augment calls in > RBT_REMOVE. I'm inclined to agree. > > The augment code is only used by uvm_map.c, and it seems to

Re: copy and paste error in rb tree code

2018-10-08 Thread Theo de Raadt
> The augment code is only used by uvm_map.c, There have been occasional problems in pmem_range below where it is used...

copy and paste error in rb tree code

2018-10-08 Thread David Gwynne
According to https://github.com/FRRouting/frr/pull/3106, Coverity thinks I made a copy and paste error regarding one of the augment calls in RBT_REMOVE. I'm inclined to agree. The augment code is only used by uvm_map.c, and it seems to be fine with this change. I believe it coped because the augme