Re: cleanup an bad and unneeded typecast in rpki-client

2020-04-16 Thread Todd C . Miller
On Thu, 16 Apr 2020 12:00:04 +0200, Claudio Jeker wrote: > There is a bit of strange code in the ip parser of rpki-client to parse > the AFI. This is a 2byte network byte order value. Instead of using a a > char buf and a short just do everything with a one uint16_t. The current > code does *(uint

cleanup an bad and unneeded typecast in rpki-client

2020-04-16 Thread Claudio Jeker
There is a bit of strange code in the ip parser of rpki-client to parse the AFI. This is a 2byte network byte order value. Instead of using a a char buf and a short just do everything with a one uint16_t. The current code does *(uint16_t)buf which is not save since buf is a char array. Lucky us tha