On Wed, Sep 02, 2020 at 01:49:02PM -0600, Theo de Raadt wrote:
> I had this diff in my tree for a while, but haven't gotten around
> to passing it up.
>
> there are other warnings in the tree, found by newer clang, that
> people should review. Some of them are just noise, in particular
> relating
Looks correct, OK millert@
- todd
On Wed, 02 Sep 2020 21:43:47 +0200, Theo Buehler wrote:
> clang 10 complains:
>
> /usr/src/usr.sbin/vmctl/vmctl.c:792:35: warning: comparing a pointer to a nul
> l character
> constant; did you mean to compare to NULL? [-Wpointer-compare]
>
I had this diff in my tree for a while, but haven't gotten around
to passing it up.
there are other warnings in the tree, found by newer clang, that
people should review. Some of them are just noise, in particular
relating to missing {}.
Theo Buehler wrote:
> clang 10 complains:
>
> /usr/src/
clang 10 complains:
/usr/src/usr.sbin/vmctl/vmctl.c:792:35: warning: comparing a pointer to a null
character
constant; did you mean to compare to NULL? [-Wpointer-compare]
'/')) == NULL || ++tty == '\0')
