Re: clang -Wpointer-sign

2016-09-24 Thread Mark Kettenis
> From: "Theo de Raadt" > Date: Sat, 24 Sep 2016 10:44:19 -0600 > > Please add this to all arch/*/conf/conf/Makefile.* files. > > We are trying to minimize differences between these files. If > that effort isn't made, they will eventually wander far apart from > each other. Sure. I'll leave l

Re: clang -Wpointer-sign

2016-09-24 Thread Theo de Raadt
Please add this to all arch/*/conf/conf/Makefile.* files. We are trying to minimize differences between these files. If that effort isn't made, they will eventually wander far apart from each other. > So clang has this warning turned on by default. And our codebase is > not clean. I don't thin

clang -Wpointer-sign

2016-09-24 Thread Mark Kettenis
So clang has this warning turned on by default. And our codebase is not clean. I don't think we intend to fix that anytime soon. In fact, I think we deliberately convert between signed and unsigned char pointers in places. So I propose to turn this warning off. Since gcc recognizes the option