Re: clang: dev/acpi/dsdt.c and dev/i2c/iatp.c

2016-09-24 Thread Jeremie Courreges-Anglas
Mark Kettenis writes: > In both cases we're comparing an array to NULL. > > Note that in dev/acpi/dsdt.c I changed the strcmp() condition to == 0; > using ! for string pointer comparison always confuses me. I can drop > that change if people consider it controversial. No objection. > ok? ok j

clang: dev/acpi/dsdt.c and dev/i2c/iatp.c

2016-09-24 Thread Mark Kettenis
In both cases we're comparing an array to NULL. Note that in dev/acpi/dsdt.c I changed the strcmp() condition to == 0; using ! for string pointer comparison always confuses me. I can drop that change if people consider it controversial. ok? Index: dev/acpi/dsdt.c ==