Re: cbfb: coreboot framebuffer console

2016-06-16 Thread Miod Vallat
> Here is a third version that just integrates the coreboot code into > efifb. The cnattach path still has to be different to allow vga to > try to attach before doing the coreboot version. > > > Index: arch/amd64/amd64/efifb.c > @@ -55,6 +102,8 @@ int efifb_show_screen(void *, void *, i

Re: cbfb: coreboot framebuffer console

2016-06-16 Thread joshua stein
On Mon, 13 Jun 2016 at 12:35:23 +0200, Mark Kettenis wrote: > > Date: Sun, 12 Jun 2016 11:47:37 -0500 > > From: joshua stein > > > > Here's a new version with feedback from Miod and Ted. > > > > It also fixes a bug on a Broadwell Chromebook (tested by Edward > > Wandasiewicz) which has proper in

Re: cbfb: coreboot framebuffer console

2016-06-15 Thread Miod Vallat
> On Wed, 15 Jun 2016 19:01:23 +0200, Mark Kettenis wrote: > >> I don't really consider it to be terribly important to rename the >> efifb(4). The chromebooks are weird machines, and I don't expect the >> coreboot-based framebuffer to show up on many systems. > > Agreed, just keep it as efifb(4).

Re: cbfb: coreboot framebuffer console

2016-06-15 Thread Todd C. Miller
On Wed, 15 Jun 2016 19:01:23 +0200, Mark Kettenis wrote: > I don't really consider it to be terribly important to rename the > efifb(4). The chromebooks are weird machines, and I don't expect the > coreboot-based framebuffer to show up on many systems. Agreed, just keep it as efifb(4). If we re

Re: cbfb: coreboot framebuffer console

2016-06-15 Thread Mark Kettenis
> From: Bryan Vyhmeister > Date: Wed, 15 Jun 2016 09:54:08 -0700 > > On Wed, Jun 15, 2016, at 09:34 AM, Bryan Steele wrote: > > On Wed, Jun 15, 2016 at 12:32:00PM -0400, Bryan Steele wrote: > > > On Wed, Jun 15, 2016 at 11:23:53AM -0500, joshua stein wrote: > > > > Any ideas for a new name? > > >

Re: cbfb: coreboot framebuffer console

2016-06-15 Thread Bryan Vyhmeister
On Wed, Jun 15, 2016, at 09:34 AM, Bryan Steele wrote: > On Wed, Jun 15, 2016 at 12:32:00PM -0400, Bryan Steele wrote: > > On Wed, Jun 15, 2016 at 11:23:53AM -0500, joshua stein wrote: > > > Any ideas for a new name? > > > > NetBSD calls their equivalent driver genfb(4). > > I wonder if it could be

Re: cbfb: coreboot framebuffer console

2016-06-15 Thread Bryan Steele
On Wed, Jun 15, 2016 at 12:32:00PM -0400, Bryan Steele wrote: > On Wed, Jun 15, 2016 at 11:23:53AM -0500, joshua stein wrote: > > On Tue, 14 Jun 2016 at 07:22:14 +0200, Joerg Jung wrote: > > > > We should not get hung up too much about the driver name. If it is > > > > felt that efifb(4) is inappr

Re: cbfb: coreboot framebuffer console

2016-06-15 Thread Bryan Steele
On Wed, Jun 15, 2016 at 11:23:53AM -0500, joshua stein wrote: > On Tue, 14 Jun 2016 at 07:22:14 +0200, Joerg Jung wrote: > > > We should not get hung up too much about the driver name. If it is > > > felt that efifb(4) is inappropriate for these chromebooks with > > > coreboot, we can always renam

Re: cbfb: coreboot framebuffer console

2016-06-15 Thread joshua stein
On Tue, 14 Jun 2016 at 07:22:14 +0200, Joerg Jung wrote: > > We should not get hung up too much about the driver name. If it is > > felt that efifb(4) is inappropriate for these chromebooks with > > coreboot, we can always rename the driver. > > Yes, renaming makes sense then. Any ideas for a ne

Re: cbfb: coreboot framebuffer console

2016-06-13 Thread Joerg Jung
Am 13.06.2016 um 12:35 schrieb Mark Kettenis : >> Date: Sun, 12 Jun 2016 11:47:37 -0500 >> From: joshua stein >> >> Here's a new version with feedback from Miod and Ted. >> >> It also fixes a bug on a Broadwell Chromebook (tested by Edward >> Wandasiewicz) which has proper inteldrm but no vga,

Re: cbfb: coreboot framebuffer console

2016-06-13 Thread Mark Kettenis
> Date: Sun, 12 Jun 2016 11:47:37 -0500 > From: joshua stein > > Here's a new version with feedback from Miod and Ted. > > It also fixes a bug on a Broadwell Chromebook (tested by Edward > Wandasiewicz) which has proper inteldrm but no vga, so cbfb was > getting chosen as the console early on bu

Re: cbfb: coreboot framebuffer console

2016-06-12 Thread joshua stein
Here's a new version with feedback from Miod and Ted. It also fixes a bug on a Broadwell Chromebook (tested by Edward Wandasiewicz) which has proper inteldrm but no vga, so cbfb was getting chosen as the console early on but then not detaching when inteldrm wanted to take over. This detaches cbfb

Re: cbfb: coreboot framebuffer console

2016-06-11 Thread Miod Vallat
> Index: arch/amd64/amd64/cbfb.c > +struct cfattach cbfb_ca = { > + sizeof(struct cbfb_softc), cbfb_match, cbfb_attach, NULL > +}; Make it const. > +void > +cbfb_rasops_preinit(struct cbfb *cbfb) > +{ > +#define bmnum(_x) (fls(_x) - ffs(_x) + 1) > +#define bmpos(_x) (ffs(_x) - 1) These two

Re: cbfb: coreboot framebuffer console

2016-06-10 Thread Ted Unangst
joshua stein wrote: > +int > +cb_parse_table(paddr_t addr) > +{ > + int i, j; > + > + for (i = 0; i < (4 * 1024); i += 16) { > + struct cb_header *cbh; > + struct cb_entry *cbe; > + void *cbtable; > + > + cbh = (struct cb_header *)(PMAP_DIRECT

Re: cbfb: coreboot framebuffer console

2016-06-10 Thread Mark Kettenis
> Date: Fri, 10 Jun 2016 14:38:05 -0500 > From: joshua stein > > This implements a new framebuffer console (based on efifb) for amd64 > devices running Coreboot, which do not have otherwise working EFI, > VGA text, inteldrm, or serial console. So mostly just Skylake > Chromebooks. > > This is r

cbfb: coreboot framebuffer console

2016-06-10 Thread joshua stein
This implements a new framebuffer console (based on efifb) for amd64 devices running Coreboot, which do not have otherwise working EFI, VGA text, inteldrm, or serial console. So mostly just Skylake Chromebooks. This is required for my HP Chromebook 13 (and would have previously been required for