Re: c99 initialize struct protosw

2017-02-21 Thread Alexander Bluhm
On Tue, Feb 21, 2017 at 11:21:15AM -0500, David Hill wrote: > Here is an updated diff without explicitly setting 0/NULL. > > --- kern/uipc_proto.c 5 Feb 2017 07:57:08 - 1.11 > +++ kern/uipc_proto.c 21 Feb 2017 00:42:46 - > +{ > + .pr_type = SOCK_STREAM, > + .pr_domain = &unixdoma

Re: c99 initialize struct protosw

2017-02-21 Thread David Hill
Here is an updated diff without explicitly setting 0/NULL. Index: kern/uipc_proto.c === RCS file: /cvs/src/sys/kern/uipc_proto.c,v retrieving revision 1.11 diff -u -p -r1.11 uipc_proto.c --- kern/uipc_proto.c 5 Feb 2017 07:57:08 -00

Re: c99 initialize struct protosw

2017-02-21 Thread Martin Pieuchot
On 20/02/17(Mon) 22:30, Mark Kettenis wrote: > David Hill schreef op 2017-02-19 03:22: > > Hello - > > > > This moves the 'struct protosw' declarations to use C99 initializers. > > Requested by mpi@ > > With C99 initializers it is no longer necessary to explicitly > initialize zero-initialized me

Re: c99 initialize struct protosw

2017-02-20 Thread Mark Kettenis
David Hill schreef op 2017-02-19 03:22: Hello - This moves the 'struct protosw' declarations to use C99 initializers. Requested by mpi@ With C99 initializers it is no longer necessary to explicitly initialize zero-initialized members (such as null-pointers). That could reduce the diff consider

Re: c99 initialize struct protosw

2017-02-19 Thread Jeremie Courreges-Anglas
David Hill writes: > Hello - > > This moves the 'struct protosw' declarations to use C99 initializers. > Requested by mpi@ ok jca@ Just one nit, [...] > Index: net/rtsock.c > === > RCS file: /cvs/src/sys/net/rtsock.c,v > retrievi

Re: c99 initialize struct protosw

2017-02-18 Thread David Hill
On Sat, Feb 18, 2017 at 09:22:44PM -0500, David Hill wrote: > Hello - > > This moves the 'struct protosw' declarations to use C99 initializers. > Requested by mpi@ > Apologies for not explaining the reason for the diff. It would allow us to easily grep for a member, such as pr_ctloutput, and kno

c99 initialize struct protosw

2017-02-18 Thread David Hill
Hello - This moves the 'struct protosw' declarations to use C99 initializers. Requested by mpi@ Index: kern/uipc_proto.c === RCS file: /cvs/src/sys/kern/uipc_proto.c,v retrieving revision 1.11 diff -u -p -r1.11 uipc_proto.c --- kern/