Re: btrace: add boolean AND and OR operators

2020-09-14 Thread Sebastien Marie
On Mon, Sep 14, 2020 at 03:28:17PM +0200, Jasper Lievisse Adriaanse wrote: > Hi, > > This diff adds support for the '&' and '|' operators, along with > a new testcase. > > OK? make sens to me. ok semarie@ > Index: usr.sbin/btrace/bt_parse.y > ===

Re: btrace: add boolean AND and OR operators

2020-09-14 Thread Jasper Lievisse Adriaanse
On Mon, Sep 14, 2020 at 03:39:04PM +0200, Otto Moerbeek wrote: > On Mon, Sep 14, 2020 at 03:28:17PM +0200, Jasper Lievisse Adriaanse wrote: > > > Hi, > > > > This diff adds support for the '&' and '|' operators, along with > > a new testcase. > > > > OK? > > The precedence looks funny > > I'd

Re: btrace: add boolean AND and OR operators

2020-09-14 Thread Otto Moerbeek
On Mon, Sep 14, 2020 at 03:28:17PM +0200, Jasper Lievisse Adriaanse wrote: > Hi, > > This diff adds support for the '&' and '|' operators, along with > a new testcase. > > OK? The precedence looks funny I'd guess you want %left '|' %left '&' %left '+' '-' %left '/' '*' To avoid suprises.

btrace: add boolean AND and OR operators

2020-09-14 Thread Jasper Lievisse Adriaanse
Hi, This diff adds support for the '&' and '|' operators, along with a new testcase. OK? Index: usr.sbin/btrace/bt_parse.y === RCS file: /cvs/src/usr.sbin/btrace/bt_parse.y,v retrieving revision 1.16 diff -u -p -r1.16 bt_parse.y ---