Re: broadcast simplex checksum

2021-02-06 Thread Alexander Bluhm
On Sat, Feb 06, 2021 at 08:26:35PM +1300, richard.n.proc...@gmail.com wrote: > I'm ok with your latest diff as-is. I prefer a slightly different > direction, see below, but not enough to object. I have commited my diff as is. It is better if you expess your arguments yourself in the comment whe

Re: broadcast simplex checksum

2021-02-05 Thread richard . n . procter
Hi, Thanks for the background. I'm ok with your latest diff as-is. I prefer a slightly different direction, see below, but not enough to object. On Mon, 1 Feb 2021, Alexander Bluhm wrote: > On Mon, Feb 01, 2021 at 08:08:56AM +1300, Richard Procter wrote: > > - Might the rule disabling checks

Re: broadcast simplex checksum

2021-02-05 Thread Alexander Bluhm
On Mon, Feb 01, 2021 at 02:04:51AM +0100, Alexander Bluhm wrote: > On Mon, Feb 01, 2021 at 08:08:56AM +1300, Richard Procter wrote: > > - Might the rule disabling checksum offload for broadcasts on IFF_SIMPLEX > > interfaces be weakened to disable checksum offload for all broadcast > > packets

Re: broadcast simplex checksum

2021-01-31 Thread Alexander Bluhm
On Mon, Feb 01, 2021 at 08:08:56AM +1300, Richard Procter wrote: > - Might the rule disabling checksum offload for broadcasts on IFF_SIMPLEX > interfaces be weakened to disable checksum offload for all broadcast > packets instead? I just copied the condition from ether_resolve():

Re: broadcast simplex checksum

2021-01-31 Thread Richard Procter
>> On 20/01/2021, at 1:56 PM, Alexander Bluhm wrote: >> >> Hi, >> >> Simplex interfaces reinject broadcast packets back into the IP >> stack. As this is a software features, no hardware checksumming >> occurs. So local broadcast packets are dropped with wrong checksum >> if the underlying ha

broadcast simplex checksum

2021-01-19 Thread Alexander Bluhm
Hi, Simplex interfaces reinject broadcast packets back into the IP stack. As this is a software features, no hardware checksumming occurs. So local broadcast packets are dropped with wrong checksum if the underlying hardware supports checksumming. Do software checksumming in ip_output() if the