Re: bpf_mtap_stripvlan

2014-07-10 Thread Henning Brauer
* Paul de Weerd [2014-07-10 14:33]: > On Thu, Jul 10, 2014 at 01:30:29PM +0100, Stuart Henderson wrote: > | On 2014/07/10 13:11, Henning Brauer wrote: > | > I committed the bpf chunk, but nothing is using it yet. pls give the > | > if_vlan.c chunk a spin. > | I think weerd@ might need something si

Re: bpf_mtap_stripvlan

2014-07-10 Thread Henning Brauer
* Stuart Henderson [2014-07-10 14:30]: > On 2014/07/10 13:11, Henning Brauer wrote: > > I committed the bpf chunk, but nothing is using it yet. pls give the > > if_vlan.c chunk a spin. > I think weerd@ might need something similar for bridge for his tv... the f&^(*$@&)($#@ bridge needs to die. I

Re: bpf_mtap_stripvlan

2014-07-10 Thread Paul de Weerd
On Thu, Jul 10, 2014 at 01:30:29PM +0100, Stuart Henderson wrote: | On 2014/07/10 13:11, Henning Brauer wrote: | > I committed the bpf chunk, but nothing is using it yet. pls give the | > if_vlan.c chunk a spin. | | I think weerd@ might need something similar for bridge for his tv... I'm testing

Re: bpf_mtap_stripvlan

2014-07-10 Thread Stuart Henderson
*ifp) > > #if NBPFILTER > 0 > if (ifp->if_bpf) > - bpf_mtap(ifp->if_bpf, m, BPF_DIRECTION_OUT); > + bpf_mtap_stripvlan(ifp->if_bpf, m, BPF_DIRECTION_OUT); > #endif > > /* > > > * Hen

Re: bpf_mtap_stripvlan

2014-07-10 Thread Henning Brauer
CTION_OUT); + bpf_mtap_stripvlan(ifp->if_bpf, m, BPF_DIRECTION_OUT); #endif /* * Henning Brauer [2014-07-09 23:46]: > so dlg noticed that tcpdump on vlan is now somewhat busted, > specifically dhc* don't work on the any more. the reason is that bpf > now sees the ether_

bpf_mtap_stripvlan

2014-07-09 Thread Henning Brauer
+#endif +} + +/* * like bpf_mtap, but copy fn can be given. used by various bpf_mtap* */ void @@ -1218,6 +1259,13 @@ void bpf_mtap(caddr_t arg, struct mbuf *m, u_int direction) { _bpf_mtap(arg, m, direction, NULL); +} + +/* like bpf_mtap, but strip the vlan header, leave regular