Re: bgpd vs gcc4

2023-01-05 Thread Claudio Jeker
On Thu, Jan 05, 2023 at 02:18:47PM +0100, David Demelier wrote: > On Thu, 2023-01-05 at 13:59 +0100, Claudio Jeker wrote: > > On Thu, Jan 05, 2023 at 11:09:57AM +0100, Theo Buehler wrote: > > > On Thu, Jan 05, 2023 at 11:03:04AM +0100, Claudio Jeker wrote: > > > > gcc4 does not really support C99 i

Re: bgpd vs gcc4

2023-01-05 Thread Theo de Raadt
> Also I thought that gcc4 defaults to -std=c99 or gnu99. Reading the code, it appears to default to c89.

Re: bgpd vs gcc4

2023-01-05 Thread Claudio Jeker
On Thu, Jan 05, 2023 at 06:01:37AM -0700, Theo de Raadt wrote: > Florian Obser wrote: > > > On 2023-01-05 11:09 +01, Theo Buehler wrote: > > > On Thu, Jan 05, 2023 at 11:03:04AM +0100, Claudio Jeker wrote: > > >> gcc4 does not really support C99 initalizers. It works most of the time > > >> but

Re: bgpd vs gcc4

2023-01-05 Thread David Demelier
On Thu, 2023-01-05 at 13:59 +0100, Claudio Jeker wrote: > On Thu, Jan 05, 2023 at 11:09:57AM +0100, Theo Buehler wrote: > > On Thu, Jan 05, 2023 at 11:03:04AM +0100, Claudio Jeker wrote: > > > gcc4 does not really support C99 initalizers. It works most of > > > the time > > > but fails for more com

Re: bgpd vs gcc4

2023-01-05 Thread Theo de Raadt
Florian Obser wrote: > On 2023-01-05 11:09 +01, Theo Buehler wrote: > > On Thu, Jan 05, 2023 at 11:03:04AM +0100, Claudio Jeker wrote: > >> gcc4 does not really support C99 initalizers. It works most of the time > >> but fails for more complex structs. Just fall back to memset() here. > > > > de

Re: bgpd vs gcc4

2023-01-05 Thread Claudio Jeker
On Thu, Jan 05, 2023 at 11:09:57AM +0100, Theo Buehler wrote: > On Thu, Jan 05, 2023 at 11:03:04AM +0100, Claudio Jeker wrote: > > gcc4 does not really support C99 initalizers. It works most of the time > > but fails for more complex structs. Just fall back to memset() here. > > deraadt used { {0}

Re: bgpd vs gcc4

2023-01-05 Thread Florian Obser
On 2023-01-05 11:09 +01, Theo Buehler wrote: > On Thu, Jan 05, 2023 at 11:03:04AM +0100, Claudio Jeker wrote: >> gcc4 does not really support C99 initalizers. It works most of the time >> but fails for more complex structs. Just fall back to memset() here. > > deraadt used { {0} } in kr_send_depen

Re: bgpd vs gcc4

2023-01-05 Thread Theo Buehler
On Thu, Jan 05, 2023 at 11:03:04AM +0100, Claudio Jeker wrote: > gcc4 does not really support C99 initalizers. It works most of the time > but fails for more complex structs. Just fall back to memset() here. deraadt used { {0} } in kr_send_dependon(). Apparently that works. I really don't understa

bgpd vs gcc4

2023-01-05 Thread Claudio Jeker
gcc4 does not really support C99 initalizers. It works most of the time but fails for more complex structs. Just fall back to memset() here. -- :wq Claudio Index: kroute.c === RCS file: /cvs/src/usr.sbin/bgpd/kroute.c,v retrieving r