Re: bgpd refactor prefix_adjout_withdraw

2022-03-02 Thread Theo Buehler
On Wed, Mar 02, 2022 at 02:46:55PM +0100, Claudio Jeker wrote: > I forgot to mention that. So during reconfigure rde_up_flush_upcall() > walks over the full adj_rib_out tree. This includes pending withdraws and > we need to properly handle them. I decided it is best to revert this back > to the way

Re: bgpd refactor prefix_adjout_withdraw

2022-03-02 Thread Claudio Jeker
On Wed, Mar 02, 2022 at 01:25:42PM +0100, Theo Buehler wrote: > On Wed, Mar 02, 2022 at 01:07:09PM +0100, Claudio Jeker wrote: > > On Wed, Mar 02, 2022 at 01:03:04PM +0100, Claudio Jeker wrote: > > > This diff changes prefix_adjout_withdraw() to take a prefix pointer > > > as argument. So instead o

Re: bgpd refactor prefix_adjout_withdraw

2022-03-02 Thread Theo Buehler
On Wed, Mar 02, 2022 at 01:07:09PM +0100, Claudio Jeker wrote: > On Wed, Mar 02, 2022 at 01:03:04PM +0100, Claudio Jeker wrote: > > This diff changes prefix_adjout_withdraw() to take a prefix pointer > > as argument. So instead of doing the lookup in the withdraw function the > > caller may need to

Re: bgpd refactor prefix_adjout_withdraw

2022-03-02 Thread Claudio Jeker
On Wed, Mar 02, 2022 at 01:03:04PM +0100, Claudio Jeker wrote: > This diff changes prefix_adjout_withdraw() to take a prefix pointer > as argument. So instead of doing the lookup in the withdraw function the > caller may need to do it. > > With this one call to up_generate_updates() can be replace

bgpd refactor prefix_adjout_withdraw

2022-03-02 Thread Claudio Jeker
This diff changes prefix_adjout_withdraw() to take a prefix pointer as argument. So instead of doing the lookup in the withdraw function the caller may need to do it. With this one call to up_generate_updates() can be replaced with a direct call to prefix_adjout_withdraw(). rde_up_flush_upcall() t