Re: [s...@spacehopper.org: ospf6d fib reload [Re: bgpd fix for possible crash in SE]]

2023-06-21 Thread Claudio Jeker
i, 26 May 2023 14:40:45 +0100 > To: tech@openbsd.org > Subject: ospf6d fib reload [Re: bgpd fix for possible crash in SE] > Mail-Followup-To: tech@openbsd.org > > On 2023/05/26 13:52, Stuart Henderson wrote: > > I think my main issues come around LS_REFRESH_TIME intervals, wh

[s...@spacehopper.org: ospf6d fib reload [Re: bgpd fix for possible crash in SE]]

2023-06-20 Thread Stuart Henderson
This hasn't blown up yet... any interest? - Forwarded message from Stuart Henderson - From: Stuart Henderson Date: Fri, 26 May 2023 14:40:45 +0100 To: tech@openbsd.org Subject: ospf6d fib reload [Re: bgpd fix for possible crash in SE] Mail-Followup-To: tech@openbsd.org On 2023/

ospf6d fib reload [Re: bgpd fix for possible crash in SE]

2023-05-26 Thread Stuart Henderson
On 2023/05/26 13:52, Stuart Henderson wrote: > I think my main issues come around LS_REFRESH_TIME intervals, when > there's loads of churn and "ospf6d: ospf engine" can be busy for > minutes at a time (not always, but very often). Don't know if that rings > any bells for anyone... (I am now reminde

Re: bgpd fix for possible crash in SE

2023-05-26 Thread Stuart Henderson
On 2023/05/25 16:15, Claudio Jeker wrote: > On Thu, May 25, 2023 at 02:20:37PM +0100, Stuart Henderson wrote: > > On 2023/05/25 15:06, Claudio Jeker wrote: > > > sthen@ reported a bgpd SE crash to me and after inspection of the report > > > it looks like he managed to trigger a mistake in session_p

Re: bgpd fix for possible crash in SE

2023-05-25 Thread Claudio Jeker
On Thu, May 25, 2023 at 02:20:37PM +0100, Stuart Henderson wrote: > On 2023/05/25 15:06, Claudio Jeker wrote: > > sthen@ reported a bgpd SE crash to me and after inspection of the report > > it looks like he managed to trigger a mistake in session_process_msg(). > > When for example a NOTIFICATION

Re: bgpd fix for possible crash in SE

2023-05-25 Thread Stuart Henderson
On 2023/05/25 15:06, Claudio Jeker wrote: > sthen@ reported a bgpd SE crash to me and after inspection of the report > it looks like he managed to trigger a mistake in session_process_msg(). > When for example a NOTIFICATION message is received then the state change > clears the rbuf. Now normally

Re: bgpd fix for possible crash in SE

2023-05-25 Thread Theo Buehler
On Thu, May 25, 2023 at 03:06:05PM +0200, Claudio Jeker wrote: > sthen@ reported a bgpd SE crash to me and after inspection of the report > it looks like he managed to trigger a mistake in session_process_msg(). > When for example a NOTIFICATION message is received then the state change > clears th

bgpd fix for possible crash in SE

2023-05-25 Thread Claudio Jeker
sthen@ reported a bgpd SE crash to me and after inspection of the report it looks like he managed to trigger a mistake in session_process_msg(). When for example a NOTIFICATION message is received then the state change clears the rbuf. Now normally the for loop starts over afterwards and the if (p-