Re: bgpd, use vstate from filterstate for update functions

2023-01-18 Thread Theo Buehler
> But those calls have either a break or continue, so either the loop is > exited or restarted (depending on PEERFLAG_EVALUATE_ALL). That's what I was missing. Not sure how. > So there should be no way to go from a rde_filterstate_clean(&state) to > prefix_adjout_update(new). > > There is a miss

Re: bgpd, use vstate from filterstate for update functions

2023-01-18 Thread Claudio Jeker
On Wed, Jan 18, 2023 at 05:53:10PM +0100, Theo Buehler wrote: > On Wed, Jan 18, 2023 at 05:37:37PM +0100, Claudio Jeker wrote: > > On Wed, Jan 18, 2023 at 05:18:58PM +0100, Theo Buehler wrote: > > > On Wed, Jan 18, 2023 at 02:46:19PM +0100, Claudio Jeker wrote: > > > > This is the next step in vsta

Re: bgpd, use vstate from filterstate for update functions

2023-01-18 Thread Theo Buehler
On Wed, Jan 18, 2023 at 05:37:37PM +0100, Claudio Jeker wrote: > On Wed, Jan 18, 2023 at 05:18:58PM +0100, Theo Buehler wrote: > > On Wed, Jan 18, 2023 at 02:46:19PM +0100, Claudio Jeker wrote: > > > This is the next step in vstate cleanup. > > > Since the vstate is now part of struct filterstate u

Re: bgpd, use vstate from filterstate for update functions

2023-01-18 Thread Claudio Jeker
On Wed, Jan 18, 2023 at 05:18:58PM +0100, Theo Buehler wrote: > On Wed, Jan 18, 2023 at 02:46:19PM +0100, Claudio Jeker wrote: > > This is the next step in vstate cleanup. > > Since the vstate is now part of struct filterstate use that information > > instead of passing an explicit vstate to the va

Re: bgpd, use vstate from filterstate for update functions

2023-01-18 Thread Theo Buehler
On Wed, Jan 18, 2023 at 02:46:19PM +0100, Claudio Jeker wrote: > This is the next step in vstate cleanup. > Since the vstate is now part of struct filterstate use that information > instead of passing an explicit vstate to the various update functions. It took me a moment to understand that rde_fi

bgpd, use vstate from filterstate for update functions

2023-01-18 Thread Claudio Jeker
This is the next step in vstate cleanup. Since the vstate is now part of struct filterstate use that information instead of passing an explicit vstate to the various update functions. -- :wq Claudio Index: rde.c === RCS file: /cvs/s