Re: bgpd, Adj-RIB-Out support

2018-11-03 Thread Denis Fondras
On Wed, Oct 31, 2018 at 09:02:16PM +0100, Denis Fondras wrote: > On Wed, Oct 31, 2018 at 04:24:49PM +0100, Claudio Jeker wrote: > > This diff introduces a real Adj-RIB-Out. It is the minimal change to > > introduce the new RIB. This removes the update_rib introduced before 6.4 > > lock because that

Re: bgpd, Adj-RIB-Out support

2018-11-01 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2018.11.01 10:38:41 +0100: > On Wed, Oct 31, 2018 at 11:55:51PM +0100, Sebastian Benoit wrote: > > Denis Fondras(open...@ledeuns.net) on 2018.10.31 21:02:17 +0100: > > > On Wed, Oct 31, 2018 at 04:24:49PM +0100, Claudio Jeker wrote: > > > > This diff intro

Re: bgpd, Adj-RIB-Out support

2018-11-01 Thread Claudio Jeker
On Wed, Oct 31, 2018 at 11:55:51PM +0100, Sebastian Benoit wrote: > Denis Fondras(open...@ledeuns.net) on 2018.10.31 21:02:17 +0100: > > On Wed, Oct 31, 2018 at 04:24:49PM +0100, Claudio Jeker wrote: > > > This diff introduces a real Adj-RIB-Out. It is the minimal change to > > > introduce the new

Re: bgpd, Adj-RIB-Out support

2018-11-01 Thread Denis Fondras
On Wed, Oct 31, 2018 at 10:02:05PM -0400, David Higgs wrote: > On Wed, Oct 31, 2018 at 6:58 PM Sebastian Benoit wrote: > > > > On a phone, saw some typos and such, sorry no diff. > > [benoit@border2:~]$ cat before > > RDE memory statistics > > 715727 IPv4 unicast network entries using 27.3

Re: bgpd, Adj-RIB-Out support

2018-10-31 Thread David Higgs
On Wed, Oct 31, 2018 at 6:58 PM Sebastian Benoit wrote: On a phone, saw some typos and such, sorry no diff. [benoit@border2:~]$ cat before > RDE memory statistics > 715727 IPv4 unicast network entries using 27.3M of memory > 58953 IPv6 unicast network entries using 3.1M of memory >

Re: bgpd, Adj-RIB-Out support

2018-10-31 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2018.10.31 16:24:49 +0100: > This diff introduces a real Adj-RIB-Out. It is the minimal change to > introduce the new RIB. This removes the update_rib introduced before 6.4 > lock because that is now replaced with a real RIB. > The code used by bgpctl show

Re: bgpd, Adj-RIB-Out support

2018-10-31 Thread Sebastian Benoit
Denis Fondras(open...@ledeuns.net) on 2018.10.31 21:02:17 +0100: > On Wed, Oct 31, 2018 at 04:24:49PM +0100, Claudio Jeker wrote: > > This diff introduces a real Adj-RIB-Out. It is the minimal change to > > introduce the new RIB. This removes the update_rib introduced before 6.4 > > lock because th

Re: bgpd, Adj-RIB-Out support

2018-10-31 Thread Sebastian Benoit
Sebastian Benoit(be...@openbsd.org) on 2018.10.31 22:26:51 +0100: > two full views v4 + v6, the usual testbox: forget this one, the machine is not really doing much with the Adj-RIB-Out.

Re: bgpd, Adj-RIB-Out support

2018-10-31 Thread Sebastian Benoit
Denis Fondras(open...@ledeuns.net) on 2018.10.31 21:02:17 +0100: > On Wed, Oct 31, 2018 at 04:24:49PM +0100, Claudio Jeker wrote: > > This diff introduces a real Adj-RIB-Out. It is the minimal change to > > introduce the new RIB. This removes the update_rib introduced before 6.4 > > lock because th

Re: bgpd, Adj-RIB-Out support

2018-10-31 Thread Denis Fondras
On Wed, Oct 31, 2018 at 04:24:49PM +0100, Claudio Jeker wrote: > This diff introduces a real Adj-RIB-Out. It is the minimal change to > introduce the new RIB. This removes the update_rib introduced before 6.4 > lock because that is now replaced with a real RIB. > The code used by bgpctl show rib is

bgpd, Adj-RIB-Out support

2018-10-31 Thread Claudio Jeker
This diff introduces a real Adj-RIB-Out. It is the minimal change to introduce the new RIB. This removes the update_rib introduced before 6.4 lock because that is now replaced with a real RIB. The code used by bgpctl show rib is now a fair amount easier since now one RIB runner can be used for all