> sad but ok dlg@
>
> On 22/05/2013, at 2:06 AM, Mark Kettenis wrote:
>
> >> From: Theo de Raadt
> >> Date: Tue, 21 May 2013 09:23:04 -0600
> >>
> >>> I'd say no. Why is the driver tearing down and reinitializing the dma
> >>> maps when a watchdog timeout happens? That's just wrong.
> >>
>
sad but ok dlg@
On 22/05/2013, at 2:06 AM, Mark Kettenis wrote:
>> From: Theo de Raadt
>> Date: Tue, 21 May 2013 09:23:04 -0600
>>
>>> I'd say no. Why is the driver tearing down and reinitializing the dma
>>> maps when a watchdog timeout happens? That's just wrong.
>>
>> Because bge_watchdo
> From: Theo de Raadt
> Date: Tue, 21 May 2013 09:23:04 -0600
>
> > I'd say no. Why is the driver tearing down and reinitializing the dma
> > maps when a watchdog timeout happens? That's just wrong.
>
> Because bge_watchdog() simply calls bge_init() to redo everything. It
> is simply the way
On 21 May 2013 17:18, Mark Kettenis wrote:
>> Date: Tue, 21 May 2013 17:10:57 +0200
>> From: Mike Belopuhov
>>
>> prevent the system from spitting loads of splasserts when bge_watchdog
>> fires. ok?
>
> I'd say no. Why is the driver tearing down and reinitializing the dma
> maps when a watchdog
> I'd say no. Why is the driver tearing down and reinitializing the dma
> maps when a watchdog timeout happens? That's just wrong.
Because bge_watchdog() simply calls bge_init() to redo everything. It
is simply the way the driver was written.
During autoconfig, NOWAIT will be OK. bge is not a
> Date: Tue, 21 May 2013 17:10:57 +0200
> From: Mike Belopuhov
>
> prevent the system from spitting loads of splasserts when bge_watchdog
> fires. ok?
I'd say no. Why is the driver tearing down and reinitializing the dma
maps when a watchdog timeout happens? That's just wrong.
> diff --git s
prevent the system from spitting loads of splasserts when bge_watchdog
fires. ok?
diff --git sys/dev/pci/if_bge.c sys/dev/pci/if_bge.c
index 055ceec..ffad959 100644
--- sys/dev/pci/if_bge.c
+++ sys/dev/pci/if_bge.c
@@ -1226,7 +1226,7 @@ bge_init_rx_ring_std(struct bge_softc *sc)
for (i