Re: ber.c: Document ber_scanf_element moving forward

2019-08-14 Thread Theo de Raadt
Martijn van Duren wrote: > On 8/14/19 4:48 PM, Claudio Jeker wrote: > > On Wed, Aug 14, 2019 at 04:37:48PM +0200, Martijn van Duren wrote: > >> On 8/14/19 3:35 PM, Claudio Jeker wrote: > >>> On Wed, Aug 14, 2019 at 02:37:14PM +0200, Martijn van Duren wrote: > This one stumped me for longer t

Re: ber.c: Document ber_scanf_element moving forward

2019-08-14 Thread Claudio Jeker
On Wed, Aug 14, 2019 at 04:51:10PM +0200, Martijn van Duren wrote: > On 8/14/19 4:48 PM, Claudio Jeker wrote: > > On Wed, Aug 14, 2019 at 04:37:48PM +0200, Martijn van Duren wrote: > >> On 8/14/19 3:35 PM, Claudio Jeker wrote: > >>> On Wed, Aug 14, 2019 at 02:37:14PM +0200, Martijn van Duren wrote:

Re: ber.c: Document ber_scanf_element moving forward

2019-08-14 Thread Martijn van Duren
On 8/14/19 4:48 PM, Claudio Jeker wrote: > On Wed, Aug 14, 2019 at 04:37:48PM +0200, Martijn van Duren wrote: >> On 8/14/19 3:35 PM, Claudio Jeker wrote: >>> On Wed, Aug 14, 2019 at 02:37:14PM +0200, Martijn van Duren wrote: This one stumped me for longer than I'd like to admit. The probl

Re: ber.c: Document ber_scanf_element moving forward

2019-08-14 Thread Claudio Jeker
On Wed, Aug 14, 2019 at 04:37:48PM +0200, Martijn van Duren wrote: > On 8/14/19 3:35 PM, Claudio Jeker wrote: > > On Wed, Aug 14, 2019 at 02:37:14PM +0200, Martijn van Duren wrote: > >> This one stumped me for longer than I'd like to admit. > >> The problem I faced was that I expected > >> ber_scan

Re: ber.c: Document ber_scanf_element moving forward

2019-08-14 Thread Martijn van Duren
On 8/14/19 3:35 PM, Claudio Jeker wrote: > On Wed, Aug 14, 2019 at 02:37:14PM +0200, Martijn van Duren wrote: >> This one stumped me for longer than I'd like to admit. >> The problem I faced was that I expected >> ber_scanf_elements(..., "{Se{", ...) to work if "e" is an nstring. >> This was not th

Re: ber.c: Document ber_scanf_element moving forward

2019-08-14 Thread Claudio Jeker
On Wed, Aug 14, 2019 at 02:37:14PM +0200, Martijn van Duren wrote: > This one stumped me for longer than I'd like to admit. > The problem I faced was that I expected > ber_scanf_elements(..., "{Se{", ...) to work if "e" is an nstring. > This was not the case because "e" doesn't increment ber and {

ber.c: Document ber_scanf_element moving forward

2019-08-14 Thread Martijn van Duren
This one stumped me for longer than I'd like to admit. The problem I faced was that I expected ber_scanf_elements(..., "{Se{", ...) to work if "e" is an nstring. This was not the case because "e" doesn't increment ber and { is tested against the nstring. Because I can see value in having it this w