Re: avoid pcb lookup in pf forward

2017-11-22 Thread Alexandr Nedvedicky
Hello, On Wed, Nov 22, 2017 at 01:45:39PM +0100, Alexander Bluhm wrote: > On Wed, Nov 22, 2017 at 09:49:06AM +0100, Alexandr Nedvedicky wrote: > > > /* if reassembled packet passed, create new fragments */ > > > - if (pf_status.reass && action == PF_PASS && pd.m && fwdir == PF_FWD) { > > > + if

Re: avoid pcb lookup in pf forward

2017-11-22 Thread Alexander Bluhm
On Wed, Nov 22, 2017 at 09:49:06AM +0100, Alexandr Nedvedicky wrote: > > /* if reassembled packet passed, create new fragments */ > > - if (pf_status.reass && action == PF_PASS && pd.m && fwdir == PF_FWD) { > > + if (pf_status.reass && action == PF_PASS && pd.m && fwdir == PF_FWD && > > +

Re: avoid pcb lookup in pf forward

2017-11-22 Thread Alexandr Nedvedicky
Hello, your change looks good to me as-is. Though the patch itself drags my attention to line here in pf_test(): > @@ -7072,7 +7083,8 @@ done: > > #ifdef INET6 > /* if reassembled packet passed, create new fragments */ > - if (pf_status.reass && action == PF_PASS && pd.m && fwdir ==

avoid pcb lookup in pf forward

2017-11-21 Thread Alexander Bluhm
Hi, markus@ pointed out that it makes no sense to call pcb lookup from pf during packet forwarding. While there remove a useless ifp parameter form ip_output_ipsec_send(). ok? bluhm Index: net/pf.c === RCS file: /data/mirror/openb