Re: asmc(4) improvements

2015-12-22 Thread Mark Kettenis
> Date: Tue, 22 Dec 2015 12:42:38 +0100 > From: Joerg Jung > > On Mon, Dec 21, 2015 at 10:38:24PM +0100, Mark Kettenis wrote: > > There were two reasons for this slowness: > > > > 1. The asmc_command() function does additional reads as a "sanity > >flush". We had to wait for these reads to

Re: asmc(4) improvements

2015-12-22 Thread Joerg Jung
On Mon, Dec 21, 2015 at 10:38:24PM +0100, Mark Kettenis wrote: > The asmc(4) driver is a bit slow. On my MacBookPro12,1 it takes a > couple of minutes to probe all the sensors. And changing the keyboard > backlight takes a couple of seconds. This is especially annoying when > you're writing a di

Re: asmc(4) improvements

2015-12-21 Thread Bryan Vyhmeister
On Tue, Dec 22, 2015 at 08:30:15AM +0100, Theo Buehler wrote: > Responsiveness of keyboard.backlight adjustment is now immediate > rather than delayed by about one second. I didn't test keyboard.backlight adjustment responsiveness initially on the MacBookAir7,2 but, as you said as well, it is inst

Re: asmc(4) improvements

2015-12-21 Thread Theo Buehler
> However, since Apple's SMC implementation almost certainly changed > over the years, it would be good to test this diff on a wider range of > Apple hardware. Please check that all sensors are still present and > are properly updated after applying this diff. Seems to be a significant improvemen

Re: asmc(4) improvements

2015-12-21 Thread Bryan Vyhmeister
On Mon, Dec 21, 2015 at 10:38:24PM +0100, Mark Kettenis wrote: > However, since Apple's SMC implementation almost certainly changed > over the years, it would be good to test this diff on a wider range of > Apple hardware. Please check that all sensors are still present and > are properly updated

asmc(4) improvements

2015-12-21 Thread Mark Kettenis
The asmc(4) driver is a bit slow. On my MacBookPro12,1 it takes a couple of minutes to probe all the sensors. And changing the keyboard backlight takes a couple of seconds. This is especially annoying when you're writing a diff to bind that functionality to the keys reserved for this purpose on