Re: [External] : arp locking

2021-04-27 Thread Alexandr Nedvedicky
Hello, On Wed, Apr 28, 2021 at 01:49:27AM +0200, Alexander Bluhm wrote: > On Wed, Apr 28, 2021 at 12:46:31AM +0200, Alexandr Nedvedicky wrote: > > looks good in general. I have just two nits/questions. > > mvs@ has asked the same questions. > > > > struct llinfo_arp { > > > - LIST_ENTRY(llinfo

Re: [External] : arp locking

2021-04-27 Thread Alexander Bluhm
On Wed, Apr 28, 2021 at 12:46:31AM +0200, Alexandr Nedvedicky wrote: > looks good in general. I have just two nits/questions. mvs@ has asked the same questions. > > struct llinfo_arp { > > - LIST_ENTRY(llinfo_arp) la_list; > > - struct rtentry *la_rt; /* backpointer to rte

Re: arp locking

2021-04-27 Thread Vitaliy Makkoveev
On Tue, Apr 27, 2021 at 07:27:43PM +0200, Alexander Bluhm wrote: > Hi, > > I would like to document the locking mechanism of the global variables > in ARP. > > The global arp_list is protected by net lock. This is not sufficent > when we switch to shared netlock. So I added a mutex for insertio

Re: [External] : arp locking

2021-04-27 Thread Alexandr Nedvedicky
Hello, looks good in general. I have just two nits/questions. > ok? > > bluhm > > Index: netinet/if_ether.c > === > RCS file: /data/mirror/openbsd/cvs/src/sys/netinet/if_ether.c,v > retrieving revision 1.246 > diff -u -p -r1.246 i

arp locking

2021-04-27 Thread Alexander Bluhm
Hi, I would like to document the locking mechanism of the global variables in ARP. The global arp_list is protected by net lock. This is not sufficent when we switch to shared netlock. So I added a mutex for insertion and removal if netlock is not exclusive. ok? bluhm Index: netinet/if_ether