Re: snmpd [11/16]: When a request results in EOMV we must return the requesting OID

2023-10-24 Thread Theo Buehler
On Tue, Oct 17, 2023 at 03:17:19PM +0200, Martijn van Duren wrote: > According to RFC3416 section 4.2.2 and 4.2.3 case "(2)" when an > endOfMibView is returned the OID must be identical to originally > requested OID. Currently this can fail when the original request > is

Re: snmpd [7/16]: Treat agentx-close-pdu with reasonByManager as a parseerror

2023-10-24 Thread Theo Buehler
On Tue, Oct 17, 2023 at 03:03:16PM +0200, Martijn van Duren wrote: > > RFC2741 section 6.2.2 says that reasonByManager can only be used by the > agentx master. Treat this reason as a parseerror. ok tb

snmpd [11/16]: When a request results in EOMV we must return the requesting OID

2023-10-17 Thread Martijn van Duren
According to RFC3416 section 4.2.2 and 4.2.3 case "(2)" when an endOfMibView is returned the OID must be identical to originally requested OID. Currently this can fail when the original request is in a !last registered region and all subsequent regions also return EOMV. Store the origin

snmpd [7/16]: Treat agentx-close-pdu with reasonByManager as a parseerror

2023-10-17 Thread Martijn van Duren
RFC2741 section 6.2.2 says that reasonByManager can only be used by the agentx master. Treat this reason as a parseerror. OK? martijn@ diff --git a/application_agentx.c b/application_agentx.c index d1efae2..2231d4c 100644 --- a/application_agentx.c +++ b/application_agentx.c @@ -576,16

Re: bgpd: announce add-path send all can hit a fatal error

2023-10-12 Thread Theo Buehler
On Thu, Oct 12, 2023 at 03:21:50PM +0200, Claudio Jeker wrote: > I optimized "announce add-path send all" to not always re-evaluate all > possible prefixes. While doing that I introduced a small bug. The problem > is that the new prefix passed to up_generate_addpath_all() coul

bgpd: announce add-path send all can hit a fatal error

2023-10-12 Thread Claudio Jeker
I optimized "announce add-path send all" to not always re-evaluate all possible prefixes. While doing that I introduced a small bug. The problem is that the new prefix passed to up_generate_addpath_all() could be not eligible. This causes up_process_prefix() -> up_test_update() to er

Re: fw_update throwing exit 1 on successful install when passed a driver by name

2023-09-22 Thread Andrew Hewus Fresh
On Fri, Sep 22, 2023 at 01:05:17PM -0500, Brian Conway wrote: > Greetings. I noticed the above behavior with the latest 7.4-beta when > scripting some fw_update runs. Perhaps a corner case was missed in the > recent work? Steps below, let me know if more information is required >

fw_update throwing exit 1 on successful install when passed a driver by name

2023-09-22 Thread Brian Conway
Greetings. I noticed the above behavior with the latest 7.4-beta when scripting some fw_update runs. Perhaps a corner case was missed in the recent work? Steps below, let me know if more information is required to reproduce. Thanks in advance. root:current-amd64.124:0:~# fw_update -d intel

Re: fix a wireguard mbuf leak

2023-09-22 Thread Alexander Bluhm
On Fri, Sep 22, 2023 at 12:21:42PM +0900, YASUOKA Masahiko wrote: > A leak may happens when wgpeer is deleted. > > ok? OK bluhm@ > The state queue should be freeed when wg_peer is destroyed. > diff from IIJ. > > I

Re: fix a wireguard mbuf leak

2023-09-22 Thread Vitaliy Makkoveev
On Fri, Sep 22, 2023 at 12:21:42PM +0900, YASUOKA Masahiko wrote: > A leak may happens when wgpeer is deleted. > > ok? > ok mvs@ > The state queue should be freeed when wg_peer is destroyed. > diff from IIJ. > >

fix a wireguard mbuf leak

2023-09-21 Thread YASUOKA Masahiko
A leak may happens when wgpeer is deleted. ok? The state queue should be freeed when wg_peer is destroyed. diff from IIJ. Index: sys/net/if_wg.c === RCS file: /disk/cvs/openbsd/src/sys/net/if_wg.c,v retrieving revision 1.29 diff -u

Re: [feature] ssh-agent: new -A option (like -a) that overwrites existing sockets

2023-09-14 Thread Stuart Henderson
On 2023/09/14 11:55, Moritz Fain wrote: > > My initial reaction is that it's easy to run "rm -f" before starting > > the agent with the existing "-a" option. same. also if there's an existing agent running you probably don't want to blindly remove t

Re: [feature] ssh-agent: new -A option (like -a) that overwrites existing sockets

2023-09-14 Thread Moritz Fain
> My initial reaction is that it's easy to run "rm -f" before starting > the agent with the existing "-a" option. > > The code seems to use a new variable that should be called "A_flag" if > it's to follow the existing naming scheme. Of c

sed(1): a,i,c text escape leading whitespace

2023-09-13 Thread Luka Krmpotić
Hello, I've noticed a bug with whitespace indentation in sed. Summary: For a,i,c `text` the leading whitespace that is intended to stay in output should be escaped, or else be ignored. The latter is not the case for sed(1) - it includes leading whitespace of `text` in the output, even if

Re: [feature] ssh-agent: new -A option (like -a) that overwrites existing sockets

2023-09-13 Thread Steffen Nurpmeso
Andreas Kähäri wrote in : |On Wed, Sep 13, 2023 at 03:08:40PM +0200, Moritz Fain wrote: |> Most of the code is already there; it's basically just adding a new flag. |> |> Happy to hear your feedback! | |My initial reaction is that it's easy to run "rm -f" bef

Re: [feature] ssh-agent: new -A option (like -a) that overwrites existing sockets

2023-09-13 Thread Andreas Kähäri
On Wed, Sep 13, 2023 at 03:08:40PM +0200, Moritz Fain wrote: > Most of the code is already there; it's basically just adding a new flag. > > Happy to hear your feedback! My initial reaction is that it's easy to run "rm -f" before starting the agent with the existing

Re: [feature] ssh-agent: new -A option (like -a) that overwrites existing sockets

2023-09-13 Thread Omar Polo
On 2023/09/13 15:08:40 +0200, Moritz Fain wrote: > Most of the code is already there; it's basically just adding a new flag. > > Happy to hear your feedback! can't comment on the diff itself, but the patch was mangled and so it doesn't apply. > --- a/usr.bin/ssh/ssh-

[feature] ssh-agent: new -A option (like -a) that overwrites existing sockets

2023-09-13 Thread Moritz Fain
Most of the code is already there; it's basically just adding a new flag. Happy to hear your feedback! --- diff --git a/usr.bin/ssh/ssh-agent.1 b/usr.bin/ssh/ssh-agent.1 index 6815eb834d3..731a1cf913d 100644 --- a/usr.bin/ssh/ssh-agent.1 +++ b/usr.bin/ssh/ssh-agent.1 @@ -76,6 +

Re: umb(4) doesn't need a custom network input function

2023-08-25 Thread Gerhard Roth
On Fri, 2023-08-25 at 20:40 +1000, David Gwynne wrote: > umb(4) is a hardware p2p driver, it just has ip coming in, so we can do > the same thing we do for the address family and input processing as > other p2p interfaces. > > the short packet check that umb_input does is already

umb(4) doesn't need a custom network input function

2023-08-25 Thread David Gwynne
umb(4) is a hardware p2p driver, it just has ip coming in, so we can do the same thing we do for the address family and input processing as other p2p interfaces. the short packet check that umb_input does is already done by the ip stacks, so we're not losing anything. i havent got a umb(4),

Re: PATCH: a bit of introspection in make

2023-08-09 Thread Thomas Frohwein
On Tue, Aug 08, 2023 at 01:02:53PM +0200, Marc Espie wrote: > Actually, as far as bsd.port.mk, it doesn't need to > move too much stuff around thanks to make's lazyness. > > Note that having a list of defined MASTER_SITES variables simplifies > the check. > >

Re: PATCH: a bit of introspection in make

2023-08-09 Thread Thomas Frohwein
On Tue, Aug 08, 2023 at 12:51:43PM +0200, Marc Espie wrote: > Here's a revised diff (reordered plus actual use of the boolean) > plus concrete example use for bsd.port.mk (disregarding the fact > _ALL_VARIABLES would have to move *after* all MASTER_SITES have been defined. I te

Re: PATCH: a bit of introspection in make

2023-08-08 Thread Marc Espie
Actually, as far as bsd.port.mk, it doesn't need to move too much stuff around thanks to make's lazyness. Note that having a list of defined MASTER_SITES variables simplifies the check. I've also added a check for the right MASTER_SITES to be defined, since currently we do not

Re: PATCH: a bit of introspection in make

2023-08-08 Thread Marc Espie
Here's a revised diff (reordered plus actual use of the boolean) plus concrete example use for bsd.port.mk (disregarding the fact _ALL_VARIABLES would have to move *after* all MASTER_SITES have been defined. Index: var.c ==

Re: PATCH: a bit of introspection in make

2023-08-07 Thread Marc Espie
On Mon, Aug 07, 2023 at 10:05:37PM -0400, Thomas Frohwein wrote: > I looked through the file and it seems that varname_list_changed is > never set to anything but true. Is there a bit missing, like down lower > in varname_list_retrieve()? Yep, I removed it at some point because it lo

Re: PATCH: a bit of introspection in make

2023-08-07 Thread Thomas Frohwein
t; > I haven't checked whether NetBSD/FreeBSD introduced something similar. > > This is a fairly straightforward patch, introduces .VARIABLES corresponding > to the full list of global variables (from the command line and the Makefile) > that have been defined. > > (^ says t

PATCH: a bit of introspection in make

2023-08-07 Thread Marc Espie
I think it could be occasionally useful to know which variables have been defined in make. Incidentally, this DOES exist in GNU make, so I've reused the same name for basically the same functionality. I haven't checked whether NetBSD/FreeBSD introduced something similar. This i

Re: vfs: drop a bunch of cast macros

2023-07-17 Thread Claudio Jeker
On Mon, Jul 17, 2023 at 11:05:03AM +0200, Sebastien Marie wrote: > On Wed, Jul 12, 2023 at 12:26:01PM +0200, thib4711 wrote: > > make it obvious in the vfsops assignment that an op isnt supported. > > I agree that it is more readable. > > ok semarie@ OK claudio@ as well. Semarie can you commit t

Re: vfs: drop a bunch of cast macros

2023-07-17 Thread Sebastien Marie
On Wed, Jul 12, 2023 at 12:26:01PM +0200, thib4711 wrote: > make it obvious in the vfsops assignment that an op isnt supported. I agree that it is more readable. ok semarie@ thanks. -- Sebastien Marie > diff --git sys/isofs/cd9660/cd9660_extern.h sys/isofs/cd9660/cd9660_extern.h > index 2a5348

vfs: drop a bunch of cast macros

2023-07-12 Thread thib4711
make it obvious in the vfsops assignment that an op isnt supported. diff --git sys/isofs/cd9660/cd9660_extern.h sys/isofs/cd9660/cd9660_extern.h index 2a5348e1768..bd8154a27bd 100644 --- sys/isofs/cd9660/cd9660_extern.h +++ sys/isofs/cd9660/cd9660_extern.h @@ -94,10 +94,8 @@ int cd9660_vptofh(stru

Re: btrace(8) allow to store kstack in a map

2023-06-27 Thread Klemens Nanni
nd improving docs later. > > Was this an OK for all of the diff? Yes, sorry if that wasn't clear. > Btw. I think this is a better version of the bt.5 change. I moved the map > specific functions into their own section. That reads

Re: btrace(8) allow to store kstack in a map

2023-06-27 Thread Claudio Jeker
> usage also seems non-intuitive. > > > > I find the documentation of bt(5) rather weak. So more is needed for sure. > > Agreed, I'm fine with your diff as-is and improving docs later. Was this an OK for all of the diff? Btw. I think this is a better version of the bt.

Re: btrace(8) allow to store kstack in a map

2023-06-26 Thread Klemens Nanni
On Mon, Jun 26, 2023 at 10:52:20PM +0200, Claudio Jeker wrote: > count() is strange since it only works on maps (at least from what I > figured out). I need to double check how min() and max() work. Since the > usage also seems non-intuitive. > > I find the documentation of bt(5) rather weak. So m

Re: btrace(8) allow to store kstack in a map

2023-06-26 Thread Claudio Jeker
000 1.14 > > +++ bt.526 Jun 2023 15:16:25 - > > @@ -120,6 +120,11 @@ Functions: > > .It Fn clear "@map" > > Delete all (key, value) pairs from > > .Va @map . > > +.It "@map[key]" = Fn count > > +Increment the value of > &g

Re: btrace(8) allow to store kstack in a map

2023-06-26 Thread Klemens Nanni
ision 1.14 > diff -u -p -r1.14 bt.5 > --- bt.5 31 Mar 2022 17:27:29 - 1.14 > +++ bt.5 26 Jun 2023 15:16:25 - > @@ -120,6 +120,11 @@ Functions: > .It Fn clear "@map" > Delete all (key, value) pairs from > .Va @map . > +.It "@map[key]&

btrace(8) allow to store kstack in a map

2023-06-26 Thread Claudio Jeker
SLIST_FOREACH(bp, &r->br_probes, bp_next) { debug("parsed probe '%s'", debug_probe_name(bp)); @@ -1685,10 +1702,17 @@ ba2dtflags(struct bt_arg *ba) long bacmp(struct bt_arg *a, struct bt_arg *b) { - assert(a->ba_type == b-&

acme-client: name resolution error when specifying a port in the api url

2023-06-01 Thread Ronald Heggenberger
/etc/acme-client.conf ``` [...] api url "https://use.some.domain.com:8443/acme/acme/directory <https://use.some.domain.com:8443/acme/acme/directory>" [...] ``` But, when I run acme-client to actually get a certificate it terminates with the following error: `

openrsync: Fix a file descriptor leak

2023-05-10 Thread Josiah Frentsos
Index: main.c === RCS file: /cvs/src/usr.bin/rsync/main.c,v retrieving revision 1.68 diff -u -p -r1.68 main.c --- main.c 28 Apr 2023 10:24:38 - 1.68 +++ main.c 10 May 2023 17:43:23 - @@ -602,6 +602,7 @@ basedir:

mg: fix spacing in a few dobeep_msgs() calls

2023-04-17 Thread Omar Polo
as per subject, when dobeep_msgs() was introduced some places weren't converted correctly: it already adds a space between the two arguments, so no need to duplicate. Index: extend.c === RCS file: /cvs/src/usr.bin/mg/exten

Re: Disabling MULTICAST flag on an interface. Force outgoing multicast traffic to a specific interface

2023-03-02 Thread Luca Di Gregorio
; >> 1) does anyone know if there is a way to disable MULTICAST on a single >> interface? >> I don't see any option in ifconfig to do this. >> > > There is not. > > >> 2) Can outgoing multicast traffic be routed to a specific interface? I >> don'

Re: Disabling MULTICAST flag on an interface. Force outgoing multicast traffic to a specific interface

2023-03-01 Thread Philip Guenther
On Wed, Mar 1, 2023 at 9:58 AM Luca Di Gregorio wrote: > 1) does anyone know if there is a way to disable MULTICAST on a single > interface? > I don't see any option in ifconfig to do this. > There is not. > 2) Can outgoing multicast traffic be routed to a specific inte

Disabling MULTICAST flag on an interface. Force outgoing multicast traffic to a specific interface

2023-03-01 Thread Luca Di Gregorio
Hi, 1) does anyone know if there is a way to disable MULTICAST on a single interface? I don't see any option in ifconfig to do this. 2) Can outgoing multicast traffic be routed to a specific interface? I don't see any option in route. It seems that the first interface, by id, is chose

Re: pinsyscall.2: Add a missing period

2023-02-18 Thread Jason McIntyre
call.2 16 Feb 2023 04:43:54 - 1.1 > +++ pinsyscall.2 18 Feb 2023 13:13:39 - > @@ -54,7 +54,7 @@ that system call must be entered from, a > entry instruction to perform the specified > .Va syscall > from a different address range will deliver > -Dv SIGABRT . &

pinsyscall.2: Add a missing period

2023-02-18 Thread Josiah Frentsos
- @@ -54,7 +54,7 @@ that system call must be entered from, a entry instruction to perform the specified .Va syscall from a different address range will deliver -Dv SIGABRT . +.Dv SIGABRT . .Sh RETURN VALUES .Rv -std .Sh ERRORS

Re: help wanted for a specific clang diff

2023-01-19 Thread Sebastien Marie
> > are putting data tables into the .text segment > > > > > > I am hoping to find someone who can do c++ well enough, and maybe > > > has some familiarity with the clang code, to add a warning message > > > for this > > > > > > if a .long

Re: help wanted for a specific clang diff

2023-01-17 Thread Sebastien Marie
ing to find someone who can do c++ well enough, and maybe > > has some familiarity with the clang code, to add a warning message > > for this > > > > if a .long, .quad, .byte are placed into a .text section, issue > > a warning, then we'll be able to identify all

Re: help wanted for a specific clang diff

2023-01-17 Thread Sebastien Marie
the clang code, to add a warning message > for this > > if a .long, .quad, .byte are placed into a .text section, issue > a warning, then we'll be able to identify all these in a ports build > and decide which need manual fixing, and move the objects into .rodata > and apply _

help wanted for a specific clang diff

2023-01-16 Thread Theo de Raadt
For this xonly work, we are having to one-by-one find .S files that are putting data tables into the .text segment I am hoping to find someone who can do c++ well enough, and maybe has some familiarity with the clang code, to add a warning message for this if a .long, .quad, .byte are placed

Re: openssh: update ed25519 and squash into a single file

2023-01-14 Thread Tobias Heider
On Sat, Jan 14, 2023 at 04:29:04PM +1100, Damien Miller wrote: > > > On Fri, 13 Jan 2023, Damien Miller wrote: > > > Hi, > > > > Forewarning: this is a big, noisy diff. Also on Github at > > https://github.com/djmdjm/openssh-wip/pull/18 > > >

Re: openssh: update ed25519 and squash into a single file

2023-01-14 Thread Theo Buehler
> This isn't completely without noise, but it lets you see the substantive > changes clearly. This looks good to me and works fine in my environment. Inlining the weird get_hram() makes things quite a bit clearer. I can't spot anything wrong in this diff. ok tb

Re: openssh: update ed25519 and squash into a single file

2023-01-13 Thread Damien Miller
On Fri, 13 Jan 2023, Damien Miller wrote: > Hi, > > Forewarning: this is a big, noisy diff. Also on Github at > https://github.com/djmdjm/openssh-wip/pull/18 > > This updates the ED25519 code to the latest version of SUPERCOP (20221122), > but the real motivation fo

Re: Making wscons a bit more like xterm

2023-01-07 Thread Nicholas Marriott
on't make bold change anything) as the terminal only supports bright and > > not true bold. > > Hummm. That would break existing behaviour in a few cases. > > Although most users are not seeing colour at all on the console, anyone who > has set TERM=pccon currently has w

Re: Making wscons a bit more like xterm

2023-01-07 Thread Crystal Kolipe
Ah, here is a trivial program to demo the new 256 color palette on the console: #include int main() { int i; printf ("\x1b[m\n"); for (i=0;i<256;i++) { printf ("\x1b[38;5;%dm#%03d %s",i,i, ((i+1) % 16 ? "" : "\n")); } printf ("

Re: Making wscons a bit more like xterm

2023-01-07 Thread Crystal Kolipe
parameters. NEW - Implement SGR 9x and 10x sequences to select 'bright' foreground and background colours, (I.E. colours 8 - 15), directly. - All the features of the previous patches. So this version is mostly to add 256 colour support. This was mainly a consequence of needi

Re: Making wscons a bit more like xterm

2023-01-07 Thread Crystal Kolipe
nothing. I've seen one program that uses it when colours <= 8, but that seems to have been an oversight. > I would be inclined to just ignore bold together with 256 colours (that is, > don't make bold change anything) as the terminal only supports bright and > not true bold. Hum

Re: Making wscons a bit more like xterm

2023-01-07 Thread Nicholas Marriott
tuff > like > > SGR 38;5;100;1 won't work. > > Well I was initially in two minds about that, because I thought there > might be > other un-official extensions that used 38 with a varying number of > parameters. > > But I haven't found any apart from 5 followed by one

Re: Making wscons a bit more like xterm

2023-01-07 Thread Nicholas Marriott
uments or stuff > like > > SGR 38;5;100;1 won't work. > > Well I was initially in two minds about that, because I thought there > might be > other un-official extensions that used 38 with a varying number of > parameters. > > But I haven't found any apart from

Re: Making wscons a bit more like xterm

2023-01-06 Thread Crystal Kolipe
hat used 38 with a varying number of parameters. But I haven't found any apart from 5 followed by one argument, and 2 followed by three RGB values, so yes I agree with you on this. However, since this morning I've been working on actually implementing 256 colour support so the next vers

Re: Making wscons a bit more like xterm

2023-01-06 Thread Nicholas Marriott
You should strictly only discard the following two arguments or stuff like SGR 38;5;100;1 won't work. This is why some people prefer the : form but the ship has rather sailed on that. On Fri, 6 Jan 2023, 11:52 Crystal Kolipe, wrote: > This version of the patchset updates a few thin

Re: Making wscons a bit more like xterm

2023-01-06 Thread Paul de Weerd
On Wed, Jan 04, 2023 at 05:42:31PM -0300, Crystal Kolipe wrote: | Hopefully it'll fix the problem. Tested with tmux, the spurious ^@'s are now indeed gone. I see there's a new diff available, so I'll try that

Re: Making wscons a bit more like xterm

2023-01-06 Thread Crystal Kolipe
This version of the patchset updates a few things since the one posted early on Wednesday: NEW - Fix two off-by-ones that caused spurious trailing null characters when requesting the terminal IDs. (Noticed by Paul running tmux.) NEW - Discard any parameters passed to a CSI 38 m or CSI 48

Re: Making wscons a bit more like xterm

2023-01-04 Thread Crystal Kolipe
lied, and my TERM set to > | > 'xterm', I do get colors in mutt and tmux. > | > | Great! Thanks for testing :). > | > | > The latter, however, shows > | > '^@^@' before the PS1 prompt upon starting a new session (`tmux new`), > | > behavior I

Re: Making wscons a bit more like xterm

2023-01-04 Thread Paul de Weerd
| Great! Thanks for testing :). | | > The latter, however, shows | > '^@^@' before the PS1 prompt upon starting a new session (`tmux new`), | > behavior I don't see with a 'real' xterm. | | This looks like an off-by-one in the wscons code, (not introduced by me!

Re: Making wscons a bit more like xterm

2023-01-04 Thread Crystal Kolipe
;^@^@' before the PS1 prompt upon starting a new session (`tmux new`), > behavior I don't see with a 'real' xterm. This looks like an off-by-one in the wscons code, (not introduced by me!) Does the following patch, (on top of the last one), fix it? --- dev/wscons/wsemul_v

Re: Making wscons a bit more like xterm

2023-01-04 Thread Paul de Weerd
Hi Crystal, I tried your patch on my laptop. With it applied, and my TERM set to 'xterm', I do get colors in mutt and tmux. The latter, however, shows '^@^@' before the PS1 prompt upon starting a new session (`tmux new`), behavior I don't see with a 'real'

Re: Making wscons a bit more like xterm

2023-01-04 Thread Crystal Kolipe
different sequences. * A new keysym has been added - KS_Backtab. * Shift-TAB is now defined as KS_Backtab and sends ESC [ Z. * Shift-F1 - Shift-F12 now send F13 - F24. * Five new escape sequences added for cursor movement. Running with this patch, all of the curses-based programs that I use on

Re: Making wscons a bit more like xterm

2023-01-02 Thread Crystal Kolipe
below about F13 - F16. * With numlock OFF, keypad 5 is now 'begin' rather than unused. * Home, End, keypad home, and keypad end now send different sequences. * A new keysym has been added - KS_Backtab. * Shift-TAB is now defined as KS_Backtab and sends ESC [ Z. * Shift-F1 - Shift-F12 now send

Re: Making wscons a bit more like xterm

2023-01-01 Thread Nicholas Marriott
Hi It is a good idea to make wscons more like xterm, at least so far as setting TERM to xterm will not cause major problems for most programs. Hardly anything uses blinking and the lack of it will bother nobody so TBH I wouldn't worry too much about it. Your diff looks good to me, althou

Making wscons a bit more like xterm

2022-12-31 Thread Crystal Kolipe
The following patch adds five escape sequences to the wscons vt100 emulation. It's one part of a larger set of patches I am working on to make the console more like xterm. Note: Casual readers of -tech and those not familar with terminfo might prefer to read my write-up at

Re: vmctl: use a space rather than tab in usage

2022-12-30 Thread Florian Obser
]\n", __progname); > + fprintf(stderr, "usage: %s [file] login\n", __progname); > + fprintf(stderr, " %s -I [file]\n", __progname); Sorry, I should have looked close what's going on. I don't think this is an improvement. Your original diff was bet

Re: vmctl: use a space rather than tab in usage

2022-12-30 Thread David Demelier
On Fri, 2022-12-30 at 14:50 +0100, Florian Obser wrote: > That seems reasonable. This might be the full list, do you want to do > all? > > usr.bin/htpasswd/htpasswd.c:fprintf(stderr, "usage:\t%s [file] > login\n", __progname); > usr.sbin/installboot/installboot.c: fprintf(stderr, "usage:\t

Re: vmctl: use a space rather than tab in usage

2022-12-30 Thread Florian Obser
022-12-30 14:45 +01, David Demelier wrote: > Most utilities seem to use a unique space between the colon and the > program name, vmctl uses a tab that will expand to two spaces once > invoked. > > e.g. > > pfctl: unknown command line argument: tata ... > usage: pfctl [-d

vmctl: use a space rather than tab in usage

2022-12-30 Thread David Demelier
Most utilities seem to use a unique space between the colon and the program name, vmctl uses a tab that will expand to two spaces once invoked. e.g. pfctl: unknown command line argument: tata ... usage: pfctl [-deghNnPqrvz] [-a anchor] [-D macro=value] [-F modifier] [-f file] tar foobar tar: f

Re: [patch(es)] fix a few typos in /src

2022-12-28 Thread Paul Tagliamonte
On Wed, Dec 28, 2022 at 09:35:52PM +, Jason McIntyre wrote: > i've finished with this diff. the usr.sbin parts i didn;t take are > listed below, along with any explanation. I *think* by my count and by watching the logs this is all of the diffs on this thread! Kudos for your steadfast review,

Re: [patch(es)] fix a few typos in /src

2022-12-28 Thread Jason McIntyre
ow to provoke integrity check failure */ /* * fpin = fopen("/tmp/passwd.enc", "a"); -* fprintf(fpin, "borken"); +* fprintf(fpin, "broken"); * fclose(fpin); */

Re: [patch(es)] fix a few typos in /src

2022-12-27 Thread Jason McIntyre
bc/include/cancel.h === RCS file: /cvs/src/lib/libc/include/cancel.h,v retrieving revision 1.5 diff -u -p -r1.5 cancel.h --- lib/libc/include/cancel.h 5 Sep 2017 02:40:54 - 1.5 +++ lib/libc/include/cancel.h 22 Dec 2022 21:14

Re: [patch(es)] fix a few typos in /src

2022-12-27 Thread Jason McIntyre
On Fri, Dec 23, 2022 at 10:33:43AM -0500, Paul Tagliamonte wrote: > On Fri, Dec 23, 2022 at 03:03:15PM +, Stuart Henderson wrote: > > > A bunch of the files in your diff come from external upstream sources > > which are still synced from upstream (or at least should be); p

Re: [patch(es)] fix a few typos in /src

2022-12-26 Thread Jason McIntyre
On Thu, Dec 22, 2022 at 10:49:06PM -0500, Paul Tagliamonte wrote: > Index: include/tib.h > === > RCS file: /cvs/src/include/tib.h,v > retrieving revision 1.8 > diff -u -p -r1.8 tib.h > --- include/tib.h 14 Jul 2020 16:48:13 -

Re: [patch(es)] fix a few typos in /src

2022-12-26 Thread Jason McIntyre
/search.c 20 Oct 2022 18:59:24 - 1.48 > +++ usr.bin/mg/search.c 23 Dec 2022 15:20:48 - > @@ -872,8 +872,8 @@ zapuptochar(int f, int n) > } > > /* > - * Prompt for a charcter and deletes from the point up to, optionally > - * including, the firs

Re: [patch(es)] fix a few typos in /src

2022-12-26 Thread Jason McIntyre
the manipulation > * of archives. The first time an archive is referenced, all of its members' > * headers are read and hashed and the archive closed again. All hashed > * archives are kept in a hash (archives) which is searched each time hi, i'm not taking this. i can;t convi

Re: [patch(es)] fix a few typos in /src

2022-12-26 Thread Jason McIntyre
itten to > + * Always true, causes the current pathname to be written to > * standard output. > */ > int > @@ -1576,7 +1576,7 @@ c_user(char *username, char ***ignored, > /* > * -xdev functions -- > * > - * Always true, causes find not to decend past

Re: [patch(es)] fix a few typos in /src

2022-12-26 Thread Jason McIntyre
d_it; /* no type is emitted > > > for void */ > > > > style(9) issue, this exceeds 80 columns > > I've reflowed the line. I shudder to think that this was done > intentionally to make it fit > doh! so without spotting this note i wondered why

Re: ksh.1: Add a missing Ns

2022-12-26 Thread Jason McIntyre
On Mon, Dec 26, 2022 at 12:11:20PM -0500, Josiah Frentsos wrote: > Index: ksh.1 > === fixed, thanks. jmc > RCS file: /cvs/src/bin/ksh/ksh.1,v > retrieving revision 1.217 > diff -u -p -r1.217 ksh.1 > --- ksh.1 13 Sep 2022 20:26:26

Re: ksh.1: Add a missing Ns

2022-12-26 Thread Josiah Frentsos
Index: ksh.1 === RCS file: /cvs/src/bin/ksh/ksh.1,v retrieving revision 1.217 diff -u -p -r1.217 ksh.1 --- ksh.1 13 Sep 2022 20:26:26 - 1.217 +++ ksh.1 26 Dec 2022 17:10:37 - @@ -2713,9 +2713,7 @@ Exit status i

Re: [patch(es)] fix a few typos in /src

2022-12-26 Thread Stuart Henderson
====== > > > > This commit contains changes to the code, it is not just a spelling fix: > > > > http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libssl/test/pkits-test.pl.diff?r1=1.1&r2=1.2&f=h > > No. This change was already there i

Re: [patch(es)] fix a few typos in /src

2022-12-26 Thread Crystal Kolipe
====== > > > > This commit contains changes to the code, it is not just a spelling fix: > > > > http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libssl/test/pkits-test.pl.diff?r1=1.1&r2=1.2&f=h > > No. This ch

Re: [patch(es)] fix a few typos in /src

2022-12-26 Thread Theo Buehler
elating to libssl. > > jmc > > > > > === > > > Index: lib/libssl/test/pkits-test.pl > > > === > > This commit contains changes to the code, it is

Re: [patch(es)] fix a few typos in /src

2022-12-26 Thread Crystal Kolipe
=== > > Index: lib/libssl/test/pkits-test.pl > > === This commit contains changes to the code, it is not just a spelling fix: http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libssl/test/pkits-test.pl.diff?r1=1.1&r2=1.2&f=h

Re: [patch(es)] fix a few typos in /src

2022-12-25 Thread Jason McIntyre
On Thu, Dec 22, 2022 at 10:49:06PM -0500, Paul Tagliamonte wrote: > > Updated patch attached with your feedback, thank you Crystal > hi. i'm rejecting these parts of this diff: Index: lib/libcurses/term.5 Index: lib/libcurses/tinfo/comp_hash.c Index: lib/libcurses/tty/hashmap.c Index: lib/libe

Re: [patch(es)] fix a few typos in /src

2022-12-25 Thread Jason McIntyre
On Thu, Dec 22, 2022 at 10:49:06PM -0500, Paul Tagliamonte wrote: hi. i've committed the parts of this diff relating to libssl. jmc > Index: lib/libssl/d1_both.c > === > Index: lib/libssl/ssl.h > =

Re: [patch(es)] fix a few typos in /src

2022-12-25 Thread Jason McIntyre
On Thu, Dec 22, 2022 at 10:49:06PM -0500, Paul Tagliamonte wrote: > > Updated patch attached with your feedback, thank you Crystal > hi. i know by now you have the message that diffs need to be manageable ;) i'll try and work through your changes as best i can. so this is a h

Re: ksh.1: Add a missing Ns

2022-12-25 Thread Jason McIntyre
On Sat, Dec 24, 2022 at 12:25:15PM -0500, Josiah Frentsos wrote: > Index: ksh.1 > === > RCS file: /cvs/src/bin/ksh/ksh.1,v > retrieving revision 1.217 > diff -u -p -r1.217 ksh.1 > --- ksh.1 13 Sep 2022 20:26:26 - 1.217 > +

ksh.1: Add a missing Ns

2022-12-24 Thread Josiah Frentsos
Index: ksh.1 === RCS file: /cvs/src/bin/ksh/ksh.1,v retrieving revision 1.217 diff -u -p -r1.217 ksh.1 --- ksh.1 13 Sep 2022 20:26:26 - 1.217 +++ ksh.1 24 Dec 2022 17:22:08 - @@ -3454,9 +3454,7 @@ option is use

Re: [patch(es)] fix a few typos in /src

2022-12-23 Thread Crystal Kolipe
On Fri, Dec 23, 2022 at 03:03:15PM +, Stuart Henderson wrote: > Overall imho this is too much churn to do in huge swathes across the > tree. > > Fixes for spelling/grammar in comments etc are often more usually > done by people working on a particular part of the tr

Re: [patch(es)] fix a few typos in /src

2022-12-23 Thread Stuart Henderson
li Offsets tables are not used in the comparison. probably "Offset tables are..." A bunch of the files in your diff come from external upstream sources which are still synced from upstream (or at least should be); patching in the OpenBSD tree makes it harder to merge in upda

Re: use a zero-copy approach for vmd virtio devices

2022-12-23 Thread Matthias Schmidt
Hi Dave, * Dave Voutila wrote: > While working back and forth with dlg@ on his idea of adding in async > task queues to vmd devices, he started to introduce a cleaner way to > handle virtqueues. In short, we can just track the host virtual address > and read/write to that location. &

Re: [patch(es)] fix a few typos in /src

2022-12-23 Thread Crystal Kolipe
36 ], > @@ -749,7 +749,7 @@ my @testlists = ( > [ "4.14.29", "Valid cRLIssuer Test29", 0 ], > > # Although this test is valid it has a circular dependency. As a result > -# an attempt is made to reursively checks a CRL path and rejected due to >

Re: use a zero-copy approach for vmd virtio devices

2022-12-23 Thread Dave Voutila
Dave Voutila writes: > While working back and forth with dlg@ on his idea of adding in async > task queues to vmd devices, he started to introduce a cleaner way to > handle virtqueues. In short, we can just track the host virtual address > and read/write to that location. >

Re: [patch(es)] fix a few typos in /src

2022-12-22 Thread Crystal Kolipe
I've only read through 50% of this so far, but there are a few issues: On Thu, Dec 22, 2022 at 06:31:23PM -0500, Paul Tagliamonte wrote: > Index: lib/libcurses/base/resizeterm.c > === > RCS file: /cvs/src/lib/

use a zero-copy approach for vmd virtio devices

2022-12-20 Thread Dave Voutila
While working back and forth with dlg@ on his idea of adding in async task queues to vmd devices, he started to introduce a cleaner way to handle virtqueues. In short, we can just track the host virtual address and read/write to that location. This has the benefit of cleaning up a good chunk of

  1   2   3   4   5   6   7   8   9   10   >