Re: Xen Patch-10: Add code to disable emulated devices

2015-12-05 Thread Mike Belopuhov
On Sat, Dec 05, 2015 at 20:13 +0100, Karel Gardas wrote: > > +void > > +xen_disable_emulated_devices(struct xen_softc *sc) > > +{ > > +#if defined(__i386__) || defined(__amd64__) > > just a nitpick, not in a position to comment on your patches but this > has caught my eyes. So far everything was j

Re: Xen Patch-10: Add code to disable emulated devices

2015-12-05 Thread Karel Gardas
> +void > +xen_disable_emulated_devices(struct xen_softc *sc) > +{ > +#if defined(__i386__) || defined(__amd64__) just a nitpick, not in a position to comment on your patches but this has caught my eyes. So far everything was just generic or amd64 specific. Now you ifdef also for i386. Is that int

Xen Patch-10: Add code to disable emulated devices

2015-12-05 Thread Mike Belopuhov
Starting with this one, all further patches are sort of work in progress. This diff implements a way to detach emulated devices (like a em network interface) in order to switch them to paravirtualized drivers (e.g. Netfront). Currently I'm not detaching anything, but provide a way to do it via th