Re: WAPBL implementation

2015-11-21 Thread Karel Gardas
On Sat, Nov 21, 2015 at 8:28 PM, Michael McConville wrote: > I agree that this is very cool. It's probably also worth mentioning that > there's a long discussion on NetBSD's tech-kernel@ right now about a > WABPL-related panic. Not sure whether that's relevant to this diff. If I've found the same

Re: WAPBL implementation

2015-11-21 Thread Karel Gardas
Hi Walter, please scratch that. The email was written based on very short experience with wapbl on a small 10gb partition. Now I've performed testing on full 500gb partition all tests done using checksumming SR RAID1. The tests differ only in mount option. rsync: 12m15s (default) -> 7m40s (softde

Re: WAPBL implementation

2015-11-21 Thread Michael McConville
I agree that this is very cool. It's probably also worth mentioning that there's a long discussion on NetBSD's tech-kernel@ right now about a WABPL-related panic. Not sure whether that's relevant to this diff.

Re: WAPBL implementation

2015-11-21 Thread Karel Gardas
Walter, this is really beautiful at least from the performance point of view. My benchmarks shows: rsync: 3m27s -> 1m20s rm: 2m13s -> 9s so speed increase is here as reported by various wapbl papers which is really nice. Anyway, I'd also like to use that with my implementation of checksumming f

Re: WAPBL implementation

2015-11-09 Thread Martin Pieuchot
Hello Walter, Thanks for this crazy diff. It is big so my first comment would be to split it to ease reviews. Here's a suggestion: - At least one diff for the kernel parts that are not WAPBL-only. In other words the refactoring needed for integrating WAPBL into FFS. This is the crit

Re: WAPBL implementation

2015-10-28 Thread Walter Neto
On Wed, Oct 28, 2015 at 12:50:24PM +0100, Jasper Lievisse Adriaanse wrote: > On Wed, Oct 28, 2015 at 09:06:54AM -0200, Walter Neto wrote: > > Adding WAPBL support for dumpfs(8) > > > > next diffs: > > - tunefs(8) showing log information and setting log size > > - fsck_ffs(8) WAPBL support > > > >

Re: WAPBL implementation

2015-10-28 Thread Jasper Lievisse Adriaanse
On Wed, Oct 28, 2015 at 09:06:54AM -0200, Walter Neto wrote: > Adding WAPBL support for dumpfs(8) > > next diffs: > - tunefs(8) showing log information and setting log size > - fsck_ffs(8) WAPBL support > > ok jasper@ Correction: I only pointed out that we should have the option to somehow get in

Re: WAPBL implementation

2015-10-28 Thread Walter Neto
Adding WAPBL support for dumpfs(8) next diffs: - tunefs(8) showing log information and setting log size - fsck_ffs(8) WAPBL support ok jasper@ Index: sbin/dumpfs/dumpfs.c === RCS file: /Volumes/CSP/cvs/src/sbin/dumpfs/dumpfs.c,v re

Re: WAPBL implementation

2015-10-23 Thread Ted Unangst
Walter Neto wrote: > Hi guys, sorry for the inconvenience. > > Once you only have use git at console, cvs is nightmare :( > > But I am learning :) this indeed looks a lot better. although it's quite the diff to review. some brave soul testing of this might be appreciated.

Re: WAPBL implementation

2015-10-23 Thread Janne Johansson
Cool. If possible, also post the diff over http with an URL or something, I don't know if your or my mailers (and the marc.info email archive) mangled the diff, but it was line-wrapped in a few places so I had to edit it for it to apply nicely. 2015-10-23 21:20 GMT+02:00 Walter Neto : > On Fri,

Re: WAPBL implementation

2015-10-23 Thread Janne Johansson
did you miss sys/wapbl.h ? cc ... -D_KERNEL -MD -MP -c ../../../../kern/vfs_bio.c ../../../../kern/vfs_bio.c:59:23: error: sys/wapbl.h: No such file or directory ../../../../kern/vfs_bio.c: In function 'bio_doread': ../../../../kern/vfs_bio.c:358: error: 'struct vnode' has no member named 'v_spec

Re: WAPBL implementation

2015-10-23 Thread Ted Unangst
Pablo Méndez Hernández wrote: > Hi, > > I would say that some information about the authors is missing... I would assume that would be included at the top of the new files, but that does point out they're missing. cvs add, then diff. (with -N if they still don't show up.)

Re: WAPBL implementation

2015-10-23 Thread Pablo Méndez Hernández
Hi, I would say that some information about the authors is missing... Regards. Pablo El 23/10/2015 5:25 p. m., "Walter Neto" escribió: > Like recommended from other developers I started developing WAPBL support > for > OpenBSD. > > Looking at NetBSD and Bitrig I mage a first funcional patch. >

Re: WAPBL implementation

2015-10-23 Thread Joerg Jung
On Fri, Oct 23, 2015 at 01:19:15PM -0200, Walter Neto wrote: > Like recommended from other developers I started developing WAPBL support for > OpenBSD. > > Looking at NetBSD and Bitrig I mage a first funcional patch. Wow... that is a big diff :) Care to elaborate in some more words what "function

WAPBL implementation

2015-10-23 Thread Walter Neto
Like recommended from other developers I started developing WAPBL support for OpenBSD. Looking at NetBSD and Bitrig I mage a first funcional patch. Index: sbin/mount/mntopts.h === RCS file: /Volumes/CSP/cvs/src/sbin/mount/mntopts.h,v