Re: Use SMR instead of SRP list in rtsock.c

2022-08-10 Thread Visa Hankala
On Wed, Aug 10, 2022 at 11:08:06AM +0200, Claudio Jeker wrote: > On Fri, Jul 01, 2022 at 04:03:21PM +, Visa Hankala wrote: > > On Fri, Jul 01, 2022 at 09:59:11AM +0200, Claudio Jeker wrote: > > > On Thu, Jun 30, 2022 at 03:46:35PM +, Visa Hankala wrote: > > > > On Thu, Jun 30, 2022 at 11:51

Re: Use SMR instead of SRP list in rtsock.c

2022-08-10 Thread Claudio Jeker
On Fri, Jul 01, 2022 at 04:03:21PM +, Visa Hankala wrote: > On Fri, Jul 01, 2022 at 09:59:11AM +0200, Claudio Jeker wrote: > > On Thu, Jun 30, 2022 at 03:46:35PM +, Visa Hankala wrote: > > > On Thu, Jun 30, 2022 at 11:51:52AM +0200, Claudio Jeker wrote: > > > > After discussing this with mp

Re: Use SMR instead of SRP list in rtsock.c

2022-07-01 Thread Visa Hankala
On Fri, Jul 01, 2022 at 09:59:11AM +0200, Claudio Jeker wrote: > On Thu, Jun 30, 2022 at 03:46:35PM +, Visa Hankala wrote: > > On Thu, Jun 30, 2022 at 11:51:52AM +0200, Claudio Jeker wrote: > > > After discussing this with mpi@ and jmatthew@ we came to the conclusion > > > that we need to smr_b

Re: Use SMR instead of SRP list in rtsock.c

2022-07-01 Thread Claudio Jeker
On Thu, Jun 30, 2022 at 03:46:35PM +, Visa Hankala wrote: > On Thu, Jun 30, 2022 at 11:51:52AM +0200, Claudio Jeker wrote: > > After discussing this with mpi@ and jmatthew@ we came to the conclusion > > that we need to smr_barrier() before refcnt_finalize() to ensure that no > > other CPU is be

Re: Use SMR instead of SRP list in rtsock.c

2022-06-30 Thread Visa Hankala
On Thu, Jun 30, 2022 at 11:51:52AM +0200, Claudio Jeker wrote: > After discussing this with mpi@ and jmatthew@ we came to the conclusion > that we need to smr_barrier() before refcnt_finalize() to ensure that no > other CPU is between the SMR_TAILQ_FOREACH, refcnt_take() and > smr_read_leave(). [.

Re: Use SMR instead of SRP list in rtsock.c

2022-06-30 Thread Vitaliy Makkoveev
On Thu, Jun 30, 2022 at 02:32:03PM +0200, Claudio Jeker wrote: > On Thu, Jun 30, 2022 at 03:21:40PM +0300, Vitaliy Makkoveev wrote: > > On Thu, Jun 30, 2022 at 11:56:55AM +0200, Claudio Jeker wrote: > > > On Thu, Jun 30, 2022 at 12:34:33PM +0300, Vitaliy Makkoveev wrote: > > > > On Thu, Jun 30, 202

Re: Use SMR instead of SRP list in rtsock.c

2022-06-30 Thread Claudio Jeker
On Thu, Jun 30, 2022 at 03:21:40PM +0300, Vitaliy Makkoveev wrote: > On Thu, Jun 30, 2022 at 11:56:55AM +0200, Claudio Jeker wrote: > > On Thu, Jun 30, 2022 at 12:34:33PM +0300, Vitaliy Makkoveev wrote: > > > On Thu, Jun 30, 2022 at 11:08:48AM +0200, Claudio Jeker wrote: > > > > This diff converts

Re: Use SMR instead of SRP list in rtsock.c

2022-06-30 Thread Vitaliy Makkoveev
On Thu, Jun 30, 2022 at 11:51:52AM +0200, Claudio Jeker wrote: > On Thu, Jun 30, 2022 at 11:08:48AM +0200, Claudio Jeker wrote: > > This diff converts the SRP list to a SMR list in rtsock.c > > SRP is a bit strange with how it works and the SMR code is a bit easier to > > understand. Since we can s

Re: Use SMR instead of SRP list in rtsock.c

2022-06-30 Thread Vitaliy Makkoveev
On Thu, Jun 30, 2022 at 11:56:55AM +0200, Claudio Jeker wrote: > On Thu, Jun 30, 2022 at 12:34:33PM +0300, Vitaliy Makkoveev wrote: > > On Thu, Jun 30, 2022 at 11:08:48AM +0200, Claudio Jeker wrote: > > > This diff converts the SRP list to a SMR list in rtsock.c > > > SRP is a bit strange with how

Re: Use SMR instead of SRP list in rtsock.c

2022-06-30 Thread Martin Pieuchot
On 30/06/22(Thu) 11:56, Claudio Jeker wrote: > On Thu, Jun 30, 2022 at 12:34:33PM +0300, Vitaliy Makkoveev wrote: > > On Thu, Jun 30, 2022 at 11:08:48AM +0200, Claudio Jeker wrote: > > > This diff converts the SRP list to a SMR list in rtsock.c > > > SRP is a bit strange with how it works and the S

Re: Use SMR instead of SRP list in rtsock.c

2022-06-30 Thread Claudio Jeker
On Thu, Jun 30, 2022 at 12:34:33PM +0300, Vitaliy Makkoveev wrote: > On Thu, Jun 30, 2022 at 11:08:48AM +0200, Claudio Jeker wrote: > > This diff converts the SRP list to a SMR list in rtsock.c > > SRP is a bit strange with how it works and the SMR code is a bit easier to > > understand. Since we c

Re: Use SMR instead of SRP list in rtsock.c

2022-06-30 Thread Claudio Jeker
On Thu, Jun 30, 2022 at 11:08:48AM +0200, Claudio Jeker wrote: > This diff converts the SRP list to a SMR list in rtsock.c > SRP is a bit strange with how it works and the SMR code is a bit easier to > understand. Since we can sleep in the SMR_TAILQ_FOREACH() we need to grab > a refcount on the rou

Re: Use SMR instead of SRP list in rtsock.c

2022-06-30 Thread Vitaliy Makkoveev
On Thu, Jun 30, 2022 at 11:08:48AM +0200, Claudio Jeker wrote: > This diff converts the SRP list to a SMR list in rtsock.c > SRP is a bit strange with how it works and the SMR code is a bit easier to > understand. Since we can sleep in the SMR_TAILQ_FOREACH() we need to grab > a refcount on the rou

Use SMR instead of SRP list in rtsock.c

2022-06-30 Thread Claudio Jeker
This diff converts the SRP list to a SMR list in rtsock.c SRP is a bit strange with how it works and the SMR code is a bit easier to understand. Since we can sleep in the SMR_TAILQ_FOREACH() we need to grab a refcount on the route pcb so that we can leave the SMR critical section and then enter the