Re: Unhibernation broken with boot.conf

2021-09-09 Thread hagen
> The hibernate check does: > > bootdev_has_hibernate(void) > { > return ((bootdev_dip->bios_info.flags & BDI_HIBVALID)? 1 : 0); > > > Someone could have a boot.conf that changes their default disk because > they want to boot from a non-standard disk. Hibernate store will occur > to swa

Re: Unhibernation broken with boot.conf

2021-09-09 Thread lists
Fri, 10 Sep 2021 01:19:23 + ha...@sdf.org > > The hibernate check does: > > > > bootdev_has_hibernate(void) > > { > > return ((bootdev_dip->bios_info.flags & BDI_HIBVALID)? 1 : 0); > > > > > > Someone could have a boot.conf that changes their default disk because > > they want to boo

Unhibernation broken with boot.conf

2021-09-09 Thread hagen
Hello tech@, Currently unhibernating doesn't work with this configuration: # echo "boot" > /etc/boot.conf The original kernel is booted instead of the hibernated one. This was fixed a few years ago for sysupgrade's /bsd.upgrade kernel but unhibernation was overlooked at the time. Before:

Re: Unhibernation broken with boot.conf

2021-09-09 Thread Theo de Raadt
The hibernate check does: bootdev_has_hibernate(void) { return ((bootdev_dip->bios_info.flags & BDI_HIBVALID)? 1 : 0); Someone could have a boot.conf that changes their default disk because they want to boot from a non-standard disk. Hibernate store will occur to swap on the non-standar

Re: Unhibernation broken with boot.conf

2021-09-09 Thread Theo de Raadt
that is a demo. It breaks hibernate. Lots of things in boot.conf could break hibernate. Why is that so surprising? You haven't explained why you need to use boot.conf But furthermore, you want to skip boot.conf parsing entirely, in the hibernate case. I believe you have ignored the potential c

Re: Unhibernation broken with boot.conf

2021-09-09 Thread Theo de Raadt
Disagree. There is no justification for what you have in /etc/boot.conf ha...@sdf.org wrote: > Hello tech@, > > Currently unhibernating doesn't work with this configuration: > > # echo "boot" > /etc/boot.conf > > The original kernel is booted instead of the hibernated one. > This was fixed a