Re: Un-const pci_attach_args var

2020-11-29 Thread Kevin Lo
On Sun, Nov 29, 2020 at 07:00:53PM -0800, Greg Steuck wrote: > > Kevin Lo writes: > > > ok? > > I guess your goal was consistency (though I'd prefer the opposite > direction). There's one more case: > > ./dev/pci/if_de.c:4401:struct pci_attach_args * const pa = (struct > pci_attach_args *

Re: Un-const pci_attach_args var

2020-11-29 Thread Greg Steuck
Kevin Lo writes: > ok? I guess your goal was consistency (though I'd prefer the opposite direction). There's one more case: ./dev/pci/if_de.c:4401:struct pci_attach_args * const pa = (struct pci_attach_args *) aux; which, funny enough, has been since rev 1.1. Thanks Greg

Un-const pci_attach_args var

2020-11-26 Thread Kevin Lo
ok? Index: sys/dev/pci/berkwdt.c === RCS file: /cvs/src/sys/dev/pci/berkwdt.c,v retrieving revision 1.9 diff -u -p -u -p -r1.9 berkwdt.c --- sys/dev/pci/berkwdt.c 8 Sep 2017 05:36:52 - 1.9 +++ sys/dev/pci/berkwdt.c