Re: USB nitpicking

2011-09-12 Thread Michael Knudsen
On Thu, Sep 08, 2011 at 03:00:27AM +0200, Michael Knudsen wrote: > if_atu.c includes kthread.h but it doesn't actually have any threads, > so include timeout.h instead since that's what's needed (usbdi.h pulls > in struct timeout). > > ohci.c uses 0 instead of NULL in a pointer assignment. Anyone

Re: USB nitpicking

2011-09-07 Thread Loganaden Velvindron
I don't have any atu(4) device. However, I do have an OHCI HUB with a keyboard hooked. No breakage up to now, and the ukbd still works fine. ohci0 at pci4 dev 0 function 0 "AT&T/Lucent USB 2-port" rev 0x10: apic 1 int 16, version 1.0, legacy support usb1 at ohci0: USB revision 1.0 uhub1 at usb1

USB nitpicking

2011-09-07 Thread Michael Knudsen
if_atu.c includes kthread.h but it doesn't actually have any threads, so include timeout.h instead since that's what's needed (usbdi.h pulls in struct timeout). ohci.c uses 0 instead of NULL in a pointer assignment. -m. Index: if_atu.c