Re: UHCI assertwaitok() fix

2010-10-09 Thread C. Bensend
> This allows me to use bluetooth again after the assertwaitok() cleanup. While this patch has been shown to have some issues and may be a different problem, this is a "me too" regarding bluetooth issues. At some point between the September 20th and October 3rd amd64 snapshots, activating bluetoo

Re: UHCI assertwaitok() fix

2010-10-08 Thread Michael Knudsen
On Fri, Oct 08, 2010 at 03:10:35PM -0500, Scot Bontrager wrote: > A less boneheaded patch. The only caller of uhci_device_setintr simply > returns the return value upwards and it also returns USBD_NOMEM in several > cases. So, this seems like the route of least resistance. Perhaps that change is f

Re: UHCI assertwaitok() fix

2010-10-08 Thread Scot Bontrager
A less boneheaded patch. The only caller of uhci_device_setintr simply returns the return value upwards and it also returns USBD_NOMEM in several cases. So, this seems like the route of least resistance. Thanks for the cluestick. Index: uhci.c =

Re: UHCI assertwaitok() fix

2010-10-08 Thread Michael Knudsen
On Fri, Oct 08, 2010 at 08:11:04AM -0500, Scot Bontrager wrote: > This allows me to use bluetooth again after the assertwaitok() cleanup. [..] > upipe->u.intr.npoll = npoll; > upipe->u.intr.qhs = > - malloc(npoll * sizeof(uhci_soft_qh_t *), M_USBHC, M_WAITOK); > + malloc(npoll * sizeof(uhci_sof

UHCI assertwaitok() fix

2010-10-08 Thread Scot Bontrager
This allows me to use bluetooth again after the assertwaitok() cleanup. Index: uhci.c === RCS file: /cvs/src/sys/dev/usb/uhci.c,v retrieving revision 1.83 diff -u uhci.c --- uhci.c 20 Sep 2010 06:54:10 - 1.83 +++ uhci.c 8 Oct 2010