Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-18 Thread Claudio Jeker
On Tue, Mar 18, 2014 at 12:28:41PM +0100, Martin Pieuchot wrote: > On 18/03/14(Tue) 11:26, Mike Belopuhov wrote: > > On 18 March 2014 07:20, Claudio Jeker wrote: > > > On Mon, Mar 17, 2014 at 11:41:38AM -0600, Theo de Raadt wrote: > > >> > What about using a more generic name which is not bound to

Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-18 Thread Martin Pieuchot
On 18/03/14(Tue) 11:26, Mike Belopuhov wrote: > On 18 March 2014 07:20, Claudio Jeker wrote: > > On Mon, Mar 17, 2014 at 11:41:38AM -0600, Theo de Raadt wrote: > >> > What about using a more generic name which is not bound to 80211 since > >> > the > >> > field is a generic pointer. This may allo

Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-18 Thread Mike Belopuhov
On 18 March 2014 07:20, Claudio Jeker wrote: > On Mon, Mar 17, 2014 at 11:41:38AM -0600, Theo de Raadt wrote: >> > What about using a more generic name which is not bound to 80211 since the >> > field is a generic pointer. This may allow us to use something similar in >> > other drivers like mpe(4

Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-17 Thread Claudio Jeker
On Mon, Mar 17, 2014 at 11:41:38AM -0600, Theo de Raadt wrote: > > What about using a more generic name which is not bound to 80211 since the > > field is a generic pointer. This may allow us to use something similar in > > other drivers like mpe(4), gif(4), gre(4). > > That is basically the only

Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-17 Thread Theo de Raadt
> What about using a more generic name which is not bound to 80211 since the > field is a generic pointer. This may allow us to use something similar in > other drivers like mpe(4), gif(4), gre(4). That is basically the only thought I had. I mean you could also start passing it as a mbuf tag, but

Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-17 Thread Claudio Jeker
On Mon, Mar 17, 2014 at 11:14:24AM +0100, Martin Pieuchot wrote: > On 14/03/14(Fri) 15:46, Martin Pieuchot wrote: > > Diff below adds a new pointer to "struct pkthdr" to explicitly pass > > some wireless nodes to the pointer without abusing the interface > > pointer that I'd like to kill. > > > >

Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-17 Thread Martin Pieuchot
On 14/03/14(Fri) 15:46, Martin Pieuchot wrote: > Diff below adds a new pointer to "struct pkthdr" to explicitly pass > some wireless nodes to the pointer without abusing the interface > pointer that I'd like to kill. > > I kept and updated the comments saying that this way of passing the > corresp

Stop abusing rcvif pointer to pass wireless nodes

2014-03-14 Thread Martin Pieuchot
Diff below adds a new pointer to "struct pkthdr" to explicitly pass some wireless nodes to the pointer without abusing the interface pointer that I'd like to kill. I kept and updated the comments saying that this way of passing the corresponding node is a hack since using a dedicated pointer does