I think we can assume that people have abs(3) these days...
This macro only had one usage, which is visible in the diff. It doesn't
look like replacing it should cause any functional changes to the
arithmetic.
ok?
Index: print-icmp6.c
Michael McConville wrote:
> Stuart Henderson wrote:
> > On 2016/01/26 20:16, Michael McConville wrote:
> > > Stuart Henderson wrote:
> > > > On 2016/01/25 22:52, Michael McConville wrote:
> > > > > fddi_bitswap is only used once, and it just adds a layer of
> > > > > indirection to its preprocessor
On 2016/01/26 20:52, Michael McConville wrote:
> Something like this?
Wait to see what others say, but that looks good to me (not yet tested).
> There's a lot to be removed from libpcap too.
We could kind-of do with updating libpcap. It's not a huge problem yet
but we are starting to run into th
Stuart Henderson wrote:
> On 2016/01/26 20:16, Michael McConville wrote:
> > Stuart Henderson wrote:
> > > On 2016/01/25 22:52, Michael McConville wrote:
> > > > fddi_bitswap is only used once, and it just adds a layer of
> > > > indirection to its preprocessor condition.
> > >
> > > Oh yuk. This
On 2016/01/26 20:16, Michael McConville wrote:
> Stuart Henderson wrote:
> > On 2016/01/25 22:52, Michael McConville wrote:
> > > fddi_bitswap is only used once, and it just adds a layer of
> > > indirection to its preprocessor condition.
> >
> > Oh yuk. This is bogus anyway, and there's no good w
Stuart Henderson wrote:
> On 2016/01/25 22:52, Michael McConville wrote:
> > fddi_bitswap is only used once, and it just adds a layer of
> > indirection to its preprocessor condition.
>
> Oh yuk. This is bogus anyway, and there's no good way to handle it. We
> dropped support for FDDI interfaces s
On 2016/01/25 22:52, Michael McConville wrote:
> fddi_bitswap is only used once, and it just adds a layer of indirection
> to its preprocessor condition.
Oh yuk. This is bogus anyway, and there's no good way to handle it.
We dropped support for FDDI interfaces so it only affect decodes of
pcap fil
fddi_bitswap is only used once, and it just adds a layer of indirection
to its preprocessor condition.
This also removes macros for BSDi and Ultrix.
ok?
Index: print-fddi.c
===
RCS file: /cvs/src/usr.sbin/tcpdump/print-fddi.c,v
ret
