Re: Route priority support for ospf6d

2017-06-19 Thread Florian Riehm
Thanks, I commited it to move forward. On 06/09/17 15:41, Claudio Jeker wrote: > On Fri, Jun 09, 2017 at 03:28:07PM +0200, Alexander Bluhm wrote: >> On Wed, May 31, 2017 at 02:29:03PM +0200, Florian Riehm wrote: >>> @@ -359,6 +333,7 @@ kr_fib_decouple(void) >>> void >>> kr_dispatch_msg(int fd,

Re: Route priority support for ospf6d

2017-06-09 Thread Claudio Jeker
On Fri, Jun 09, 2017 at 03:28:07PM +0200, Alexander Bluhm wrote: > On Wed, May 31, 2017 at 02:29:03PM +0200, Florian Riehm wrote: > > @@ -359,6 +333,7 @@ kr_fib_decouple(void) > > void > > kr_dispatch_msg(int fd, short event, void *bula) > > { > > + /* XXX this is stupid */ > > dispatch_rt

Re: Route priority support for ospf6d

2017-06-09 Thread Alexander Bluhm
On Wed, May 31, 2017 at 02:29:03PM +0200, Florian Riehm wrote: > @@ -359,6 +333,7 @@ kr_fib_decouple(void) > void > kr_dispatch_msg(int fd, short event, void *bula) > { > + /* XXX this is stupid */ > dispatch_rtmsg(); > } I guess this comment refers to the event_loopexit(NULL) in osp

Route priority support for ospf6d

2017-05-31 Thread Florian Riehm
Hi, this diff adds priority support to ospf6d. Mostly based on the following ospfd commit: cvs diff -D "2008-12-11" -D "2008-12-13" Additionally I removed the RTF_UP from hdr.rtm_flags in send_rtmsg(). Ospfd and bgpd also don't set the flag. The next steps will be to add support for ospf6ctl fib

Re: multipath / route priority support for ospf6d

2017-05-23 Thread Alexander Bluhm
On Mon, May 15, 2017 at 08:43:02PM +0200, Florian Riehm wrote: > > The attached patch ports the multipath support from ospfd to ospf6d. > @@ -171,48 +260,30 @@ kr_change(struct kroute *kroute) >* - zero out ifindex (this is no longer relevant) >*/ >

Re: multipath / route priority support for ospf6d

2017-05-15 Thread Florian Riehm
On 05/12/17 18:07, Florian Riehm wrote: > Hi, > > our QA reports issues with the ospf6d since the kernel uses more multipath > routes. > It exits after certain topology changes with: > rde_send_change_kroute: no valid nexthop found > > Since the kernel uses more multipath routes, the lack of mult

multipath / route priority support for ospf6d

2017-05-12 Thread Florian Riehm
Hi, our QA reports issues with the ospf6d since the kernel uses more multipath routes. It exits after certain topology changes with: rde_send_change_kroute: no valid nexthop found Since the kernel uses more multipath routes, the lack of multipath support in ospf6d became a problem. The attached