Re: Replace getprogname() to argv[0] in bnaddsub

2018-07-20 Thread Kinichiro Inoguchi
Currently, argv[0] is used in regression tests and command line tools only, and it is not in libraries. But, I'll try to think of that. Thanks. On Fri, Jul 20, 2018 at 05:56:07AM -0600, Theo de Raadt wrote: > Disagree with this. argv[0] could be a long path, which could info > disclose directory

Re: Replace getprogname() to argv[0] in bnaddsub

2018-07-20 Thread Theo de Raadt
Let me see if I understand what you think: Windows lacks the *BSD extension getprogname(), but it surely must have the older *BSD extension __progname That about sum it up? Thanks... Gleydson Soares wrote: > On Tue, Jul 17, 2018 at 10:09:37PM +0900, Kinichiro Inoguchi wrote: > > To run regres

Re: Replace getprogname() to argv[0] in bnaddsub

2018-07-20 Thread Theo de Raadt
Disagree with this. argv[0] could be a long path, which could info disclose directory hierarchy into a context that bounces stderr to the wrong place. Instead, the Windows compat should have a have a getprogname() stub which does the right thing. Kinichiro Inoguchi wrote: > To run regress bnad

Re: Replace getprogname() to argv[0] in bnaddsub

2018-07-17 Thread Kinichiro Inoguchi
__progname is not portable, and I once requested to eliminate it. For porable reason, I prefer to using argv[0]. Anyway, thanks for your comment. Kinichiro Inoguchi On Tue, Jul 17, 2018 at 12:01:59PM -0300, Gleydson Soares wrote: > On Tue, Jul 17, 2018 at 10:09:37PM +0900, Kinichiro Inoguchi wrot

Re: Replace getprogname() to argv[0] in bnaddsub

2018-07-17 Thread Gleydson Soares
On Tue, Jul 17, 2018 at 10:09:37PM +0900, Kinichiro Inoguchi wrote: > To run regress bnaddsub on Windows, I would like to supersede getprogname > with argv[0] since it is not on Windows. > > OK ? > > Index: regress/lib/libcrypto/bn/addsub/bnaddsub.c > =

Replace getprogname() to argv[0] in bnaddsub

2018-07-17 Thread Kinichiro Inoguchi
To run regress bnaddsub on Windows, I would like to supersede getprogname with argv[0] since it is not on Windows. OK ? Index: regress/lib/libcrypto/bn/addsub/bnaddsub.c === RCS file: /cvs/src/regress/lib/libcrypto/bn/addsub/bnaddsub