Re: PATCH: remove "dead code" in make

On Sun, Sep 03, 2023 at 06:47:49PM +0200, Marc Espie wrote: > On Thu, Aug 31, 2023 at 08:59:53AM +0200, Marc Espie wrote: > > A long time ago, I tried to host our fork of make, in the hope it would get > > picked up by other systems. > > > > Accordingly, some features were added to mimic netbsd's

Re: PATCH: remove "dead code" in make

On Thu, Aug 31, 2023 at 08:59:53AM +0200, Marc Espie wrote: > A long time ago, I tried to host our fork of make, in the hope it would get > picked up by other systems. > > Accordingly, some features were added to mimic netbsd's extensions, hidden > behind FEATURES macros. > > Turns out that, for

PATCH: remove "dead code" in make

A long time ago, I tried to host our fork of make, in the hope it would get picked up by other systems. Accordingly, some features were added to mimic netbsd's extensions, hidden behind FEATURES macros. Turns out that, for better or for worse, FreeBSD decided to go with NetBSD's fork of bmake, so

[patch] Remove dead code in uvm_pmr_getpages()

Hello. The diff in this email removes dead code in uvm_pmr_getpages(). This had bothered me for a bit because I had intuitively believed it wasn't necessary, but had never bothered to fully convince myself. Since I have now, I'll share the reasoning. This diff concerns the following bit of code:

Re: libc/regex: remove dead code

On Tue, 29 Dec 2020 09:50:16 +, Miod Vallat wrote: > cclasses[] multis field is always an empty string. Remove it and code > dealing with it. This code was incomplete anyway. OK millert@ - todd

libc/regex: remove dead code

cclasses[] multis field is always an empty string. Remove it and code dealing with it. This code was incomplete anyway. Index: cclass.h === RCS file: /OpenBSD/src/lib/libc/regex/cclass.h,v retrieving revision 1.6 diff -u -p -r1.6 ccla

diff: remove dead code in a{rm,md}64/a{rm,md}/conf.c

Hi, the cdev_joy_init makro is just used in i386. OK? Bye, Jan Index: amd64/amd64/conf.c === RCS file: /cvs/src/sys/arch/amd64/amd64/conf.c,v retrieving revision 1.71 diff -u -p -r1.71 conf.c --- amd64/amd64/conf.c 6 Jul 2020 04:3

Re: diff: remove dead code in a{rm,md}64/a{rm,md}/conf.c

> Date: Wed, 7 Oct 2020 15:14:32 +0200 > From: Jan Klemkow > > Hi, > > the cdev_joy_init makro is just used in i386. > > OK? ok kettenis@ > Index: amd64/amd64/conf.c > === > RCS file: /cvs/src/sys/arch/amd64/amd64/conf.c,v > retr

Re: acpitoshiba: remove dead code

> On 16 Mar 2020, at 09:49, Stefan Sperling wrote: > > On Mon, Mar 16, 2020 at 09:29:43AM +0100, Jasper Lievisse Adriaanse wrote: >> Hi, >> >> The type of brightness and video_output is uint32_t; therefore it >> can never be less than 0 (which is what HCI_LCD_BRIGHTNESS_MIN and >> HCI_VIDEO_O

Re: acpitoshiba: remove dead code

On Mon, Mar 16, 2020 at 09:29:43AM +0100, Jasper Lievisse Adriaanse wrote: > Hi, > > The type of brightness and video_output is uint32_t; therefore it > can never be less than 0 (which is what HCI_LCD_BRIGHTNESS_MIN and > HCI_VIDEO_OUTPUT_CYCLE_MIN are defined to). So trim the checks by > removig

Re: acpitoshiba: remove dead code

On Mon, Mar 16, 2020 at 09:29:43AM +0100, Jasper Lievisse Adriaanse wrote: > Hi, > > The type of brightness and video_output is uint32_t; therefore it > can never be less than 0 (which is what HCI_LCD_BRIGHTNESS_MIN and > HCI_VIDEO_OUTPUT_CYCLE_MIN are defined to). So trim the checks by > removig

acpitoshiba: remove dead code

Hi, The type of brightness and video_output is uint32_t; therefore it can never be less than 0 (which is what HCI_LCD_BRIGHTNESS_MIN and HCI_VIDEO_OUTPUT_CYCLE_MIN are defined to). So trim the checks by removig the impossible cases. Coverity CID 1453109, 1453169 OK? Index: acpi/acpitoshiba.c ==

Re: uplcom: remove dead code

> Date: Wed, 11 Mar 2020 13:38:12 +0100 > From: Jasper Lievisse Adriaanse > > Hi, > > Remove dead code which is actually duplicated a few lines above > right after err is set. Coverity ID 975917 > > OK? ok kettenis@

uplcom: remove dead code

Hi, Remove dead code which is actually duplicated a few lines above right after err is set. Coverity ID 975917 OK? Index: dev/usb/uplcom.c === RCS file: /cvs/src/sys/dev/usb/uplcom.c,v retrieving revision 1.73 diff -u -p -U11

npppd(8): remove dead code

There is some code that dates back to 2010 and cannot compile if -DUSE_NPPPD_ARP. So I guess we can safely remove. Denis Index: npppd/npppd.c === RCS file: /cvs/src/usr.sbin/npppd/npppd/npppd.c,v retrieving revision 1.49 diff -u -p

netstat remove dead code

Anyone want to use this #if 0 code? It is off since 7 years. -- :wq Claudio Index: if.c === RCS file: /cvs/src/usr.bin/netstat/if.c,v retrieving revision 1.70 diff -u -p -r1.70 if.c --- if.c16 Jan 2015 06:40:09 - 1.

Remove dead code

maybe someone could verify & commit this patch as key domain is handled by ‘pfkey_init’, this ‘ADDDOMAIN(key)’ goes nowhere. in fact, this ‘keydomain’ variable never exist since introduced in r1.9 of 'src/sys/kern/uipc_domain.c’ which dates back to 1999 define ‘__KAME__’ in 'src/sys/kern/uipc_do

frag6 remove dead code

Hi, Remove the IPv6 fragment overlapping length adjustment code. It was already #if 0 and will never come back. Remove unused fragment struct fields and sort the others. ok? bluhm Index: netinet6/frag6.c === RCS file: /data/mirr