Re: Recursive NET_LOCK()

2017-01-05 Thread Ted Unangst
Mike Belopuhov wrote: > The big problem with the non-recursive netlock is that to fix > recursions in many cases we have to release the netlock in one > of the callers up the chain which makes the interim code run > without any protection and we don't have a way of assessing > the situation short o

Re: Recursive NET_LOCK()

2017-01-05 Thread Martin Pieuchot
On 05/01/17(Thu) 16:09, Mike Belopuhov wrote: > [...] > The big problem with the non-recursive netlock is that to fix > recursions in many cases we have to release the netlock in one > of the callers up the chain which makes the interim code run > without any protection and we don't have a way of

Re: Recursive NET_LOCK()

2017-01-05 Thread Mike Belopuhov
On 3 January 2017 at 20:08, Ted Unangst wrote: > Martin Pieuchot wrote: >> It seems that most of the problems exposed by the introduction of the >> NET_LOCK() are related to the non-recursive nature of the rwlock. Some >> known issues involve pflow(4), cloning interfaces an NFS. >> >> Diff below

Re: Recursive NET_LOCK()

2017-01-04 Thread Alexander Bluhm
On Tue, Jan 03, 2017 at 08:21:58PM +0100, Martin Pieuchot wrote: > I am also looking for more feedbacks and/or inputs so I appreciate your > email on the matter. Together with a coworker Zaur Molotnikov we are using static code analysis to find places where a netlock is needed. We try to create p

Re: Recursive NET_LOCK()

2017-01-03 Thread Mark Kettenis
> Date: Tue, 3 Jan 2017 17:13:27 +0100 > From: Martin Pieuchot > > It seems that most of the problems exposed by the introduction of the > NET_LOCK() are related to the non-recursive nature of the rwlock. Some > known issues involve pflow(4), cloning interfaces an NFS. > > Diff below makes use

Re: Recursive NET_LOCK()

2017-01-03 Thread Martin Pieuchot
On 03/01/17(Tue) 14:08, Ted Unangst wrote: > Martin Pieuchot wrote: > > It seems that most of the problems exposed by the introduction of the > > NET_LOCK() are related to the non-recursive nature of the rwlock. Some > > known issues involve pflow(4), cloning interfaces an NFS. > > > > Diff below

Re: Recursive NET_LOCK()

2017-01-03 Thread Ted Unangst
Martin Pieuchot wrote: > It seems that most of the problems exposed by the introduction of the > NET_LOCK() are related to the non-recursive nature of the rwlock. Some > known issues involve pflow(4), cloning interfaces an NFS. > > Diff below makes use of a recursive-rwlock instead. I just finis

Re: Recursive NET_LOCK()

2017-01-03 Thread Sebastien Marie
On Tue, Jan 03, 2017 at 05:13:27PM +0100, Martin Pieuchot wrote: > It seems that most of the problems exposed by the introduction of the > NET_LOCK() are related to the non-recursive nature of the rwlock. Some > known issues involve pflow(4), cloning interfaces an NFS. > > Diff below makes use of

Recursive NET_LOCK()

2017-01-03 Thread Martin Pieuchot
It seems that most of the problems exposed by the introduction of the NET_LOCK() are related to the non-recursive nature of the rwlock. Some known issues involve pflow(4), cloning interfaces an NFS. Diff below makes use of a recursive-rwlock instead. I just finished a build on NFS with it, so I'