Re: Questions about the code review process in OpenBSD

2022-11-07 Thread Stuart Henderson
On 2022/11/04 23:32, i...@tutanota.com wrote: > I am trying to understand how the code review process is conducted in > OpenBSD. I can see all the OK's in the commit log, but not every commit > has the OK. > > On FreeBSD there where a serious problem with a developer who was hired > to by Netgear

Re: Questions about the code review process in OpenBSD

2022-11-07 Thread Peter Nicolai Mathias Hansteen
> 6. nov. 2022 kl. 21:32 skrev i...@tutanota.com: > > I am the sysadmin at our company responsible for the OpenBSD > based projects. When I read about the problems at FreeBSD, after > which I wrote to their list, I was sure that the process was different > in OpenBSD, to which several users on Fre

Re: Questions about the code review process in OpenBSD

2022-11-07 Thread bug
On Mon, Nov 07, 2022 at 03:48:27AM +0100, i...@tutanota.com wrote: > > I'm sorry I cannot communicate any longer with you because you won't> give > > assurances that your company doesn't have really terrible> practices.> > > > Or, maybe you are just speaking dishonestly.I am literally laughing my

Re: Questions about the code review process in OpenBSD

2022-11-06 Thread iio7
> I'm sorry I cannot communicate any longer with you because you won't> give > assurances that your company doesn't have really terrible> practices.> > Or, > maybe you are just speaking dishonestly.I am literally laughing my ass of, > you haven't changed a bit sinceback in 1996 with the FreeBSD

Re: Questions about the code review process in OpenBSD

2022-11-06 Thread Theo de Raadt
i...@tutanota.com wrote: > Nov 6, 2022, 21:14 by dera...@openbsd.org: > > > I suspect your company forces children to make shoes, and your bosses > > kick dogs and cats. Can you provide evidence that is not true? > > > > that is what your messages come off like. > > > > Grow up. > > > I am

Re: Questions about the code review process in OpenBSD

2022-11-06 Thread iio7
Nov 6, 2022, 21:14 by dera...@openbsd.org: > I suspect your company forces children to make shoes, and your bosses > kick dogs and cats. Can you provide evidence that is not true? > > that is what your messages come off like. > > Grow up. > I am sorry that you read it this way, but that was

Re: Questions about the code review process in OpenBSD

2022-11-06 Thread Tom Smyth
IIO7 It would be best that you Check out the commit logs and look at marc.info (archives of mailing lists) ...( at the historical discussions on features / issues of interest to you .. ) it would be better that you do that rather than diverting developers resources from what they do best... yo

Re: Questions about the code review process in OpenBSD

2022-11-06 Thread Theo de Raadt
i...@tutanota.com wrote: > Nov 6, 2022, 21:00 by dera...@openbsd.org: > > > Everything is provided with no warranty and you cannot insist on us > > telling you what our processes are. > > > > You are out of line. > > > I am not insisting on anything, I am simply asking. > > We have supported th

Re: Questions about the code review process in OpenBSD

2022-11-06 Thread iio7
Nov 6, 2022, 21:00 by dera...@openbsd.org: > Everything is provided with no warranty and you cannot insist on us > telling you what our processes are. > > You are out of line. > I am not insisting on anything, I am simply asking. We have supported the project for many years and even know we ve

Re: Questions about the code review process in OpenBSD

2022-11-06 Thread Theo de Raadt
i...@tutanota.com wrote: > Nov 6, 2022, 20:16 by dera...@openbsd.org: > > > Mr iio7, > > > > Your persistant questions as to our processes are pointless. > > > > You are asking these questions in this way to interfere. > > > > That is a dickhead move. > > > > Everyone can see it. > > > Well, then

Re: Questions about the code review process in OpenBSD

2022-11-06 Thread iio7
Nov 6, 2022, 20:16 by dera...@openbsd.org: > Mr iio7, > > Your persistant questions as to our processes are pointless. > > You are asking these questions in this way to interfere. > > That is a dickhead move. > > Everyone can see it. > Well, then everyone needs glasses because I am NOT asking to i

Re: Questions about the code review process in OpenBSD

2022-11-06 Thread Theo de Raadt
i...@tutanota.com wrote: > >>> That is not your responsibility. It is mine. > >>> > >>> You can stop asking. > > I replied of list (by mistake by pressing reply rather than reply to all): > > >> Why do you keep wasting your precious time with these completely > >> useless comments? > > To which

Re: Questions about the code review process in OpenBSD

2022-11-06 Thread iio7
>>> That is not your responsibility. It is mine. >>> >>> You can stop asking. I replied of list (by mistake by pressing reply rather than reply to all): >> Why do you keep wasting your precious time with these completely >> useless comments? To which Theo answered back: > Hi Mr. Dickhead. > > D

Re: Questions about the code review process in OpenBSD

2022-11-05 Thread Theo de Raadt
That is not your responsibility. It is mine. You can stop asking. >I am trying to understand how the code review process is conducted in >OpenBSD. I can see all the OK's in the commit log, but not every commit >has the OK. > >On FreeBSD there where a serious problem with a developer who was hire

Re: Questions about the code review process in OpenBSD

2022-11-04 Thread iio7
Nov 5, 2022, 00:19 by ch...@nmedia.net: > i...@tutanota.com [i...@tutanota.com] wrote: > >> >> Is it a condition for code to go into the OpenBSD source tree (not >> talking about ports) that at least one other developer has reviewed the >> code? >> > > Yes > >> Is there a process in place to guara

Re: Questions about the code review process in OpenBSD

2022-11-04 Thread Chris Cappuccio
i...@tutanota.com [i...@tutanota.com] wrote: > > Is it a condition for code to go into the OpenBSD source tree (not > talking about ports) that at least one other developer has reviewed the > code? > Yes > Is there a process in place to guarantee this? > Yes, manual review all the way down. I

Questions about the code review process in OpenBSD

2022-11-04 Thread iio7
I am trying to understand how the code review process is conducted in OpenBSD. I can see all the OK's in the commit log, but not every commit has the OK. On FreeBSD there where a serious problem with a developer who was hired to by Netgear to create a WireGuard VPN implementation as a kernel-mode