Re: Potential free uninitialized pointer in kern_ktrace.c

2015-08-01 Thread Todd C. Miller
On Sat, 01 Aug 2015 12:12:01 -0700, Philip Guenther wrote: > Since my error was moving code across a goto, I'm inclined to kill the > goto completely, like this: That is easier to follow to boot. OK millert@ - todd

Re: Potential free uninitialized pointer in kern_ktrace.c

2015-08-01 Thread Philip Guenther
On Sat, Aug 1, 2015 at 12:05 PM, Doug Hogan wrote: > On Sat, Aug 01, 2015 at 07:31:58PM +0100, Mark Latimer wrote: >> reading through the compiler warnings I believe there is a potential issue >> in /usr/src/sys/kern/kern_ktrace.c At first glance it appears to free >> an uninitialized pointer memp

Re: Potential free uninitialized pointer in kern_ktrace.c

2015-08-01 Thread Doug Hogan
On Sat, Aug 01, 2015 at 07:31:58PM +0100, Mark Latimer wrote: > reading through the compiler warnings I believe there is a potential issue > in /usr/src/sys/kern/kern_ktrace.c At first glance it appears to free > an uninitialized pointer memp. I agree. Index: sys/kern/kern_ktrace.c =

Potential free uninitialized pointer in kern_ktrace.c

2015-08-01 Thread Mark Latimer
Hello, reading through the compiler warnings I believe there is a potential issue in /usr/src/sys/kern/kern_ktrace.c At first glance it appears to free an uninitialized pointer memp. Regards int ktruser(struct proc *p, const char *id, const void *addr, size_t len) { struct ktr_header kth