Re: Patch for boot for enabling gate A20 with BIOS

2010-03-01 Thread Giuseppe Magnotta
Tobias Weingartner wrote: > So, if you think this is something that should go in, then I'd > implore you to get more testing and test reports. I'd be wanting > all the MB/BIOS/cpu combinations that were tested before this is > committed. Testing a high number of MB/BIOS/cpu requires a lot of time

Re: Patch for boot for enabling gate A20 with BIOS

2010-03-01 Thread Tobias Weingartner
On Monday, March 1, Giuseppe Magnotta wrote: > > My question is, if this functionality is available in the BIOS, why > can't we use it? The problem is having a broken BIOS out there that simply hangs because you're calling something that it does not support. When this stuff was written, there we

Re: Patch for boot for enabling gate A20 with BIOS

2010-03-01 Thread Thomas Pfaff
On Mon, 01 Mar 2010 18:51:31 +0100 Giuseppe Magnotta wrote: > > My question is, if this functionality is available in the BIOS, why > can't we use it? > I'm just jumping in here, but I think the obvious answer is; if it is not needed on any existing platform, what purpose does it serve?

Re: Patch for boot for enabling gate A20 with BIOS

2010-03-01 Thread Giuseppe Magnotta
Tobias Weingartner wrote: > While I applaud your efforts to send in patches, I do have a > small niggle. Why do you feel the need to splatter your > authorship all over the code in comments? Why not just add > your name to the copyright statement and be done with it? Yes, You're right. It may se

Re: Patch for boot for enabling gate A20 with BIOS

2010-03-01 Thread Tobias Weingartner
On Monday, March 1, Giuseppe Magnotta wrote: > > +/* > + * Author: Giuseppe Magnotta While I applaud your efforts to send in patches, I do have a small niggle. Why do you feel the need to splatter your authorship all over the code in comments? Why not just add your name to the copyright statem

Re: Patch for boot for enabling gate A20 with BIOS

2010-03-01 Thread Giuseppe Magnotta
Ted Unangst wrote: > Can you explain this? I'd think A20 issues would have been sorted out > 15 years ago. Hi, reading gateA20.c code, I've found that only two methods for enabling the A20 line were used: the fast gate that use the I/O port 0x92 and the "classic" one that use the keyboard contro

Re: Patch for boot for enabling gate A20 with BIOS

2010-03-01 Thread Ted Unangst
On Mon, Mar 1, 2010 at 10:15 AM, Giuseppe Magnotta wrote: > Sorry, > > it seems that the patch was not included in my last email. > > Here is the patch: > > Index: gateA20.c Can you explain this? I'd think A20 issues would have been sorted out 15 years ago.

Re: Patch for boot for enabling gate A20 with BIOS

2010-03-01 Thread Giuseppe Magnotta
Sorry, it seems that the patch was not included in my last email. Here is the patch: Index: gateA20.c === RCS file: /cvs/src/sys/arch/i386/stand/libsa/gateA20.c,v retrieving revision 1.10 diff -u -r1.10 gateA20.c --- gateA20.c 19

Patch for boot for enabling gate A20 with BIOS

2010-03-01 Thread Giuseppe Magnotta
Hello, please find attached a patch for "boot" that allows it to enable the gate A20 directly by the BIOS if the INT 15/AX=2401h is supported for i386 machines. If you can please test it and tell me if it works as expected. Regards, Giuseppe. [demime 1.01d removed an attachment of type text/