Re: PCI interrupt functions

2019-06-01 Thread Mark Kettenis
> From: "Theo de Raadt" > Date: Fri, 31 May 2019 15:34:18 -0600 > > > On arm64, pci_intr_handle_t is a pointer to an opaque struct. > > That's a subtle trap. How would someone realize the order is wrong... > > Would it not be better if this was done like the other architectures, > where the pc

Re: PCI interrupt functions

2019-05-31 Thread Theo de Raadt
> On arm64, pci_intr_handle_t is a pointer to an opaque struct. That's a subtle trap. How would someone realize the order is wrong... Would it not be better if this was done like the other architectures, where the pci_intr_handle_t is a structure, not a pointer. On arm64, the pci subsystems see

PCI interrupt functions

2019-05-31 Thread Mark Kettenis
To set up an interrupt handler for a PCI device, you need to do something like this: pci_intr_handle_t ih; pci_intr_map(pa, &ih); printf(": %s", pci_intr_string(pa->pa_pc, ih)); pci_intr_establish(pa->pa_pc, ih, ...); On arm64, pci_intr_handle_t is a pointer to an opaque