Re: PATCH: ftp: allow @ in username for Basic Auth

2014-07-05 Thread Philip Guenther
On Tue, Jul 1, 2014 at 7:09 AM, Sébastien Marie wrote: > On Sun, Jun 29, 2014 at 09:52:28PM -0700, Philip Guenther wrote: > > > > Here's a patch to do that. > > > > > > Just a comment in code (unused variables in urldecode). > > > Else it seems ok. And my use-case works. > > > > Dang it, I just n

Re: PATCH: ftp: allow @ in username for Basic Auth

2014-07-01 Thread Sébastien Marie
On Sun, Jun 29, 2014 at 09:52:28PM -0700, Philip Guenther wrote: > > > Here's a patch to do that. > > > > Just a comment in code (unused variables in urldecode). > > Else it seems ok. And my use-case works. > > Dang it, I just noticed that I had sent an earlier version of my diff, > which had pr

Re: PATCH: ftp: allow @ in username for Basic Auth

2014-06-29 Thread Philip Guenther
On Thu, 26 Jun 2014, S?bastien Marie wrote: > On Wed, Jun 25, 2014 at 07:07:30PM -0700, Philip Guenther wrote: > > On Wed, 25 Jun 2014, S?bastien Marie wrote: > > > On Tue, Jun 24, 2014 at 10:55:44AM -0700, Philip Guenther wrote: > > > > On Tue, Jun 24, 2014 at 9:01 AM, S?bastien Marie < > > > > se

Re: PATCH: ftp: allow @ in username for Basic Auth

2014-06-25 Thread Sébastien Marie
On Wed, Jun 25, 2014 at 07:07:30PM -0700, Philip Guenther wrote: > On Wed, 25 Jun 2014, S?bastien Marie wrote: > > On Tue, Jun 24, 2014 at 10:55:44AM -0700, Philip Guenther wrote: > > > On Tue, Jun 24, 2014 at 9:01 AM, S?bastien Marie < > > > semarie-open...@latrappe.fr> wrote: > ... > > So, I thin

Re: PATCH: ftp: allow @ in username for Basic Auth

2014-06-25 Thread Philip Guenther
On Wed, 25 Jun 2014, S?bastien Marie wrote: > On Tue, Jun 24, 2014 at 10:55:44AM -0700, Philip Guenther wrote: > > On Tue, Jun 24, 2014 at 9:01 AM, S?bastien Marie < > > semarie-open...@latrappe.fr> wrote: ... > > Sorry, the patch is incorrect; per RFC 3986, the parser is correct to > > split the

Re: PATCH: ftp: allow @ in username for Basic Auth

2014-06-25 Thread Sébastien Marie
On Tue, Jun 24, 2014 at 10:55:44AM -0700, Philip Guenther wrote: > On Tue, Jun 24, 2014 at 9:01 AM, Sébastien Marie < > semarie-open...@latrappe.fr> wrote: > > > As I see not activity or feedback for this one line patch, I think it > > need more explain ? > > > > Sorry, the patch is incorrect; pe

Re: PATCH: ftp: allow @ in username for Basic Auth

2014-06-24 Thread Philip Guenther
On Tue, Jun 24, 2014 at 9:01 AM, Sébastien Marie < semarie-open...@latrappe.fr> wrote: > As I see not activity or feedback for this one line patch, I think it > need more explain ? > Sorry, the patch is incorrect; per RFC 3986, the parser is correct to split the authority on the first '@'. The c

Re: PATCH: ftp: allow @ in username for Basic Auth

2014-06-24 Thread Sébastien Marie
Hi, As I see not activity or feedback for this one line patch, I think it need more explain ? Currently, when you pass an URL with user/pass embed, the code parse it badly. For example: https://mym...@example.com:my-passw...@another-domain.example.com/blabla Just before the code search if the s

PATCH: ftp: allow @ in username for Basic Auth

2014-06-23 Thread Sébastien Marie
Hi, Using ftp(1) with HTTP(S) scheme and Basic auth, it is currently not possible to have username (or password) with a '@' inner. For example, this URI is badly parsed: ftp https://mym...@example.com:my-passw...@another-domain.example.com/blabla According to RFC2617, '@' is a valid character in