Re: PATCH: avoid clobbering errno before err/warn

2014-07-19 Thread Philip Guenther
On Sat, Jul 19, 2014 at 6:57 PM, Doug Hogan wrote: > On Sat, Jul 19, 2014 at 06:40:54PM -0700, Philip Guenther wrote: > > Nice job! Committed (except for the microcode/bwi file where your diff > > revealed another existing bug that we can fix at the same time...) > > Thanks! Here's the patch wi

Re: PATCH: avoid clobbering errno before err/warn

2014-07-19 Thread Doug Hogan
On Sat, Jul 19, 2014 at 06:40:54PM -0700, Philip Guenther wrote: > Nice job! Committed (except for the microcode/bwi file where your diff > revealed another existing bug that we can fix at the same time...) Thanks! Here's the patch with the existing bug fixed. I checked other places for err/war

Re: PATCH: avoid clobbering errno before err/warn

2014-07-19 Thread Philip Guenther
On Fri, Jul 11, 2014 at 10:44 PM, Doug Hogan wrote: > This patch is generated by coccinelle, but I reviewed it. I changed the > lpr patch to use warnc() so it has less code executing inside > PRIV_START. > > I targeted if statements where it modifies errno before warn or err is > called. It che

PATCH: avoid clobbering errno before err/warn

2014-07-11 Thread Doug Hogan
This patch is generated by coccinelle, but I reviewed it. I changed the lpr patch to use warnc() so it has less code executing inside PRIV_START. I targeted if statements where it modifies errno before warn or err is called. It checked a list of functions that are typically used in error handlin