Re: NET_LOCK in sppp_keepalive

2017-01-05 Thread Alexander Bluhm
On Thu, Jan 05, 2017 at 10:38:00PM +0100, Alexander Bluhm wrote: > Manual inspection shows that the last function is used in a timeout. > timeout_set(&keepalive_ch, sppp_keepalive, NULL); Of course we need a process context to call NET_LOCK(). New diff. bluhm Index: net/if_spppsubr.c ==

NET_LOCK in sppp_keepalive

2017-01-05 Thread Alexander Bluhm
Hi, My static code analysis has found a missing netlock. Starting from a given function it finds reverse traces that have no NET_LOCK(). Lock not found: [CGNode: if_linkstate, CGNode: if_down, CGNode: sppp_keepalive] Manual inspection shows that the last function is used in a timeout. timeout_