[PATCH 1/2] libressl/srp: fix potential undefined return value in SRP_Calc_client_key()

--- src/crypto/srp/srp_lib.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/crypto/srp/srp_lib.c b/src/crypto/srp/srp_lib.c index 15e751c..0875b29 100644 --- a/src/crypto/srp/srp_lib.c +++ b/src/crypto/srp/srp_lib.c @@ -256,7 +256,7 @@ BIGNUM *SRP_Calc_A(BIGNUM

Re: LibreSSL SRP fix

Hi, > That said, I think the DigestUpdate and similar checks are unnecessary > and complicate the code more than they help. Those functions really > can't fail. Hmm, which ones specifically? In particular for DigestUpdate I always wondered why that should fail, but adding a few error checks usual

Re: LibreSSL SRP fix

On Wed, Jun 04, 2014 at 18:17, Florian Zumbiehl wrote: > Hi all, > > may I draw your attention to this (my) ticket in the OpenSSL bug tracker? > > http://rt.openssl.org/Ticket/Display.html?id=3226&user=guest&pass=guest > > The patch adds various error checks and fixes an undefined return value i

LibreSSL SRP fix

Hi all, may I draw your attention to this (my) ticket in the OpenSSL bug tracker? http://rt.openssl.org/Ticket/Display.html?id=3226&user=guest&pass=guest The patch adds various error checks and fixes an undefined return value in case of error that could happen despite the error checking that's i