Re: LibreSSL: GOWindows support

2014-11-21 Thread Brent Cook
Thanks everyone for the feedback so far. I made some improvements to Windows poll emulation functions to handle errno impedance mismatches, POLLHUP and out-of-band data. Keep in mind that windows select is quite different than anything else when reviewing that code - it is not bitmap-based. I also

Re: LibreSSL: GOWindows support

2014-11-20 Thread Brent Cook
On Tue, Nov 11, 2014 at 8:41 AM, Brent Cook wrote: > I gave the openbsd src patches a spin last night. I wonder if there's > a way we could instead coerce mingw into pretending to be more POSIX > by way of header tricks in the portable tree: Hi Dongsheng, Thanks for doing the initial test port w

Re: LibreSSL: GOWindows support

2014-11-11 Thread Brent Cook
I gave the openbsd src patches a spin last night. I wonder if there's a way we could instead coerce mingw into pretending to be more POSIX by way of header tricks in the portable tree: Create a stubs for each POSIX network header, e.g. include/sys/socket.h: #ifndef _WIN32 #include_next #else #in

Re: LibreSSL: GOWindows support

2014-11-07 Thread Dongsheng Song
On Fri, Nov 7, 2014 at 11:07 PM, Brent Cook wrote: > >> On Nov 7, 2014, at 8:21 AM, Dongsheng Song wrote: >> >> I need some code changes for Windows support. >> e.g. >> >> --- a/src/lib/libssl/src/crypto/bio/bss_dgram.c >> +++ b/src/lib/libssl/src/crypto/bio/bss_dgram.c >> @@ -57,13 +57,17 @@ >>

Re: LibreSSL: GOWindows support

2014-11-07 Thread Brent Cook
> On Nov 7, 2014, at 8:21 AM, Dongsheng Song wrote: > > I need some code changes for Windows support. > e.g. > > --- a/src/lib/libssl/src/crypto/bio/bss_dgram.c > +++ b/src/lib/libssl/src/crypto/bio/bss_dgram.c > @@ -57,13 +57,17 @@ > * > */ > > +#ifdef _WIN32 > +#include > +#else > #includ

LibreSSL: GOWindows support

2014-11-07 Thread Dongsheng Song
I need some code changes for Windows support. e.g. --- a/src/lib/libssl/src/crypto/bio/bss_dgram.c +++ b/src/lib/libssl/src/crypto/bio/bss_dgram.c @@ -57,13 +57,17 @@ * */ +#ifdef _WIN32 +#include +#else #include -#include - #include +#include +#endif + +#include #include -#include