Re: Kill NFS-only kqueue poller thread

2020-05-31 Thread Visa Hankala
On Sun, May 31, 2020 at 09:40:47AM +0200, Martin Pieuchot wrote: > On 30/05/20(Sat) 15:49, Visa Hankala wrote: > > [...] > > Local filesystems can observe changes at the source, which makes polling > > unnecessary. NFS clients do not have that benefit. The NFSv3 protocol > > lacks a mechanism to n

Re: Kill NFS-only kqueue poller thread

2020-05-31 Thread Martin Pieuchot
On 30/05/20(Sat) 15:49, Visa Hankala wrote: > [...] > Local filesystems can observe changes at the source, which makes polling > unnecessary. NFS clients do not have that benefit. The NFSv3 protocol > lacks a mechanism to notify clients of changes. > > The NFS polling mechanism is in use for exam

Re: Kill NFS-only kqueue poller thread

2020-05-31 Thread Martin Pieuchot
On 30/05/20(Sat) 09:25, Theo de Raadt wrote: > [...] > What does this have to do with threads? That is an implimentation detail. This implementation detail is specific to NFS, no other FS do anything like that. So I'm questioning whether calling kthread_create(9) inside a kqueue(2) handler, whi

Re: Kill NFS-only kqueue poller thread

2020-05-30 Thread Visa Hankala
On Sat, May 30, 2020 at 03:34:06PM +0200, Martin Pieuchot wrote: > On 30/05/20(Sat) 09:22, Visa Hankala wrote: > > On Thu, May 28, 2020 at 12:11:20PM +0200, Martin Pieuchot wrote: > > > When it comes to kqueue filters NFS is special. A custom thread is > > > created when the first event is registe

Re: Kill NFS-only kqueue poller thread

2020-05-30 Thread Martin Pieuchot
On 30/05/20(Sat) 09:22, Visa Hankala wrote: > On Thu, May 28, 2020 at 12:11:20PM +0200, Martin Pieuchot wrote: > > When it comes to kqueue filters NFS is special. A custom thread is > > created when the first event is registered. Its purpose is to poll > > for changes every 2.5sec. This logic ha

Re: Kill NFS-only kqueue poller thread

2020-05-30 Thread Visa Hankala
On Thu, May 28, 2020 at 12:11:20PM +0200, Martin Pieuchot wrote: > When it comes to kqueue filters NFS is special. A custom thread is > created when the first event is registered. Its purpose is to poll > for changes every 2.5sec. This logic has been inherited from NetBSD > and is not present in

Kill NFS-only kqueue poller thread

2020-05-28 Thread Martin Pieuchot
When it comes to kqueue filters NFS is special. A custom thread is created when the first event is registered. Its purpose is to poll for changes every 2.5sec. This logic has been inherited from NetBSD and is not present in FreeBSD. Since filt_nfsread() only check `n_size' of a given nfsnode ha