Re: Include packet timestamp into the mbuf packet header

2017-05-02 Thread Theo de Raadt
> > diff --git sys/sys/mbuf.h sys/sys/mbuf.h > > index 202ce8ced8b..7ca1a779fe0 100644 > > --- sys/sys/mbuf.h > > +++ sys/sys/mbuf.h > > @@ -127,10 +127,11 @@ structpkthdr { > > u_int16_tph_flowid; /* pseudo unique flow id */ > > u_int16_tcsum_fla

Re: Include packet timestamp into the mbuf packet header

2017-05-02 Thread Miod Vallat
> diff --git sys/sys/mbuf.h sys/sys/mbuf.h > index 202ce8ced8b..7ca1a779fe0 100644 > --- sys/sys/mbuf.h > +++ sys/sys/mbuf.h > @@ -127,10 +127,11 @@ struct pkthdr { > u_int16_tph_flowid; /* pseudo unique flow id */ > u_int16_tcsum_flags;/* check

Re: Include packet timestamp into the mbuf packet header

2017-05-02 Thread Mike Belopuhov
On Tue, May 02, 2017 at 10:58 -0600, Theo de Raadt wrote: > Most important reason to me is less mbuf growth > > But what units is this timestamp... > Right now it's up to the code using it with a preference for a nanosecond precision, but once we start using it for more than one thing, we can fix

Re: Include packet timestamp into the mbuf packet header

2017-05-02 Thread Theo de Raadt
Most important reason to me is less mbuf growth But what units is this timestamp... > As it appears, there's an argument to use a single 64 bit integer > instead. Whether use a signed or value or not is debatable, but > here's an argument to go for signed: time_t, timespec and timeval > are all

Re: Include packet timestamp into the mbuf packet header

2017-05-02 Thread Mike Belopuhov
On Fri, Apr 28, 2017 at 15:31 +0200, Mike Belopuhov wrote: > One of the prerequisites for FQ_CoDel is ability to track packet > enqueue time. To avoid allocating per-packet mbuf tags, I'd prefer > to include the timestamp directly into the packet header structure. > This can be later used for othe

Re: Include packet timestamp into the mbuf packet header

2017-04-28 Thread Mike Belopuhov
On Fri, Apr 28, 2017 at 07:54 -0600, Theo de Raadt wrote: > > One of the prerequisites for FQ_CoDel is ability to track packet > > enqueue time. To avoid allocating per-packet mbuf tags, I'd prefer > > to include the timestamp directly into the packet header structure. > > This can be later used f

Re: Include packet timestamp into the mbuf packet header

2017-04-28 Thread Theo de Raadt
> One of the prerequisites for FQ_CoDel is ability to track packet > enqueue time. To avoid allocating per-packet mbuf tags, I'd prefer > to include the timestamp directly into the packet header structure. > This can be later used for other purposes as well if need be. OK? > > diff --git sys/sys

Include packet timestamp into the mbuf packet header

2017-04-28 Thread Mike Belopuhov
One of the prerequisites for FQ_CoDel is ability to track packet enqueue time. To avoid allocating per-packet mbuf tags, I'd prefer to include the timestamp directly into the packet header structure. This can be later used for other purposes as well if need be. OK? diff --git sys/sys/mbuf.h sys/