Re: Format string check for dprintf(3)

2020-09-11 Thread Theo de Raadt
ok deraadt Christian Weisgerber wrote: > Add format string checking annotations for dprintf(3) and vdprintf(3). > > This was apparently forgotten when the functions were added. It is > required so the compiler can warn > > t.c:25:25: warning: format string is not a string literal (potentially

Re: Format string check for dprintf(3)

2020-09-10 Thread Todd C . Miller
On Thu, 10 Sep 2020 20:19:14 +0200, Christian Weisgerber wrote: > Absent -Werror, I do not expect any fallout from this, but I ran a > successful amd64 make build with it anyway. OK millert@ - todd

Format string check for dprintf(3)

2020-09-10 Thread Christian Weisgerber
Add format string checking annotations for dprintf(3) and vdprintf(3). This was apparently forgotten when the functions were added. It is required so the compiler can warn t.c:25:25: warning: format string is not a string literal (potentially insecure) [-Wformat-security] dprintf(S