Re: Fix use-after-free in yppush(8)

2014-11-04 Thread Todd C. Miller
On Tue, 04 Nov 2014 14:27:39 +, Dimitris Papastamos wrote: > It seems to me that we should not free `pfd' at this point. The saved > max poll fd is not reset to 0 and I do not see any guarantees that `pfd' > will point to valid memory after calling free() here. > > Other code that follows th

Fix use-after-free in yppush(8)

2014-11-04 Thread Dimitris Papastamos
Hi, It seems to me that we should not free `pfd' at this point. The saved max poll fd is not reset to 0 and I do not see any guarantees that `pfd' will point to valid memory after calling free() here. Other code that follows the same style, like mountd(8) and rpc.rstatd(8) do not do this. OK?